-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize Result::as_deref
and as_deref_mut
#74948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
📌 Commit 68017c2d4ad7018696e56219bceb3d878801acb0 has been approved by |
@bors r- Libcore tests need to be updated. error[E0599]: no method named `as_deref_err` found for reference `&std::result::Result<u8, &i32>` in the current scope
--> library/core/tests/result.rs:257:24
|
257 | assert_eq!(ref_err.as_deref_err(), expected_result);
| ^^^^^^^^^^^^ method not found in `&std::result::Result<u8, &i32>` |
68017c2
to
0b61b61
Compare
0b61b61
to
6d293ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
📌 Commit 6d293ed has been approved by |
☀️ Test successful - checks-actions, checks-azure |
FCP completed in #50264 (comment).
This PR stabilizes two methods for
std::result::Result
:This PR also removes two rarely used unstable methods from
Result
:Closes #50264