-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core::task::yield_now #74335
Closed
Closed
Add core::task::yield_now #74335
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
use crate::future::Future; | ||
use crate::pin::Pin; | ||
use crate::task::{Context, Poll}; | ||
|
||
/// Cooperatively gives up a timeslice to the executor. | ||
/// | ||
/// Calling this function calls move the currently executing future to the back | ||
/// of the execution queue, making room for other futures to execute. This is | ||
/// especially useful after running CPU-intensive operations inside a future. | ||
/// | ||
/// # Examples | ||
/// | ||
/// Basic usage: | ||
/// | ||
/// ``` | ||
/// #![feature(task_yield_now)] | ||
/// # async fn run() { | ||
/// # | ||
/// use core::task; | ||
/// | ||
/// task::yield_now().await; | ||
/// # | ||
/// # } | ||
/// ``` | ||
#[unstable(feature = "task_yield_now", issue = "74331")] | ||
#[inline] | ||
pub fn yield_now() -> YieldNow { | ||
YieldNow { is_polled: false } | ||
} | ||
|
||
/// Creates a future that yields back to the executor exactly once. | ||
/// | ||
/// This `struct` is created by the [`yield_now`] function. See its | ||
/// documentation for more. | ||
#[unstable(feature = "task_yield_now", issue = "74331")] | ||
#[must_use = "futures do nothing unless you `.await` or poll them"] | ||
#[derive(Debug)] | ||
pub struct YieldNow { | ||
is_polled: bool, | ||
} | ||
|
||
#[unstable(feature = "task_yield_now", issue = "74331")] | ||
impl Future for YieldNow { | ||
type Output = (); | ||
|
||
// Most futures executors are implemented as a FIFO queue, so all this | ||
// future does is re-schedule the future back to the end of the queue, | ||
// giving room for other futures to progress. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Shouldn't this assumption be mentioned in the doc comments? |
||
fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
if self.is_polled { | ||
return Poll::Ready(()); | ||
} | ||
|
||
self.is_polled = true; | ||
cx.waker().wake_by_ref(); | ||
Poll::Pending | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling this function doesn’t do anything, awaiting the returned future does. The rest of this sentence sounds like a definitive guarantee whereas the comment in the code says "most executors" which is a much weaker.
This doc should probably be rephrased along the lines of: