Add PartialEq impls for Vec <-> slice #74194

mbrubeck · 2020-07-09T18:23:13Z

This is a follow-up to #71660 and rust-lang/rfcs#2917 to add two more missing vec/slice PartialEq impls:

impl<A, B> PartialEq<[B]> for Vec<A> where A: PartialEq<B> { .. }
impl<A, B> PartialEq<Vec<B>> for [A] where A: PartialEq<B> { .. }

Since this is insta-stable, it should go through the @rust-lang/libs FCP process. Note that I used version 1.47.0 for the stable attribute because I assume this will not merge before the 1.46.0 branch is cut next week.

rust-highfive · 2020-07-09T18:23:17Z

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

mbrubeck · 2020-07-09T18:27:07Z

The motivation is to allow easier comparisons between types like &Vec<T> and &[T], which will work after this patch thanks to the blanket impls of PartialEq for reference types. Currently, such comparisons fail with potentially-confusing diagnostics:

https://users.rust-lang.org/t/strange-coercion-during-comparison/43153

withoutboats · 2020-07-09T20:44:06Z

👍 on adding this but noting that it seems hard to run into since you'd have to have one of the operands be a slice, which is an unsized type.

possibly this shows up in errors as a result of bounds with things like &T where U: PartialEq<T>

LukasKalbertodt · 2020-07-12T08:53:46Z

Code looks good to me. Reassigning to start FCP.

r? @sfackler

bors · 2020-07-28T03:11:15Z

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

mbrubeck · 2020-08-01T20:40:41Z

Rebased to fix the merge conflicts.

Is this ready for FCP?

Amanieu · 2020-08-09T23:46:54Z

@rfcbot fcp merge

rfcbot · 2020-08-09T23:46:55Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

mbrubeck · 2020-08-27T20:30:32Z

Updated the stable-since version to 1.48.0 since this did not make the 1.47.0 beta branch. Ping @KodrAus @SimonSapin @sfackler @withoutboats for FCP signoff.

Dylan-DPC-zz · 2020-09-16T20:06:08Z

@KodrAus @SimonSapin @withoutboats waiting on you to vote on the fcp above or address any concerns that exist with this PR :) Thanks

rfcbot · 2020-09-16T22:41:10Z

🔔 This is now entering its final comment period, as per the review above. 🔔

pickfire · 2020-09-17T03:40:21Z

library/alloc/tests/vec.rs

@@ -1594,7 +1594,7 @@ fn partialeq_vec_and_prim() {
 }

 macro_rules! assert_partial_eq_valid {
-    ($a2:ident, $a3:ident; $b2:ident, $b3: ident) => {
+    ($a2:expr, $a3:expr; $b2:expr, $b3: expr) => {


Suggested change

($a2:expr, $a3:expr; $b2:expr, $b3: expr) => {

($a2:expr,$a3:expr; $b2:expr,$b3: expr) => {

We could make it similar to how it was written.

rfcbot · 2020-09-26T22:41:18Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

sfackler · 2020-10-06T17:26:05Z

@bors r+

bors · 2020-10-06T17:26:07Z

📌 Commit b4b3839 has been approved by sfackler

bors · 2020-10-06T19:17:58Z

⌛ Testing commit b4b3839 with merge 6ce387ce160556d2a65454958307c256401a56ff...

bors · 2020-10-06T20:23:37Z

💔 Test failed - checks-actions

mbrubeck · 2020-10-06T22:46:03Z

@bors retry

This was apparently a spurious failure caused by infrastructure problems. Not sure if I have appropriate permissions for this bors command; let's see...

bors · 2020-10-06T22:46:05Z

@mbrubeck: 🔑 Insufficient privileges: not in try users

Amanieu · 2020-10-06T22:46:58Z

@bors retry

bors · 2020-10-07T01:20:18Z

⌛ Testing commit b4b3839 with merge 5779815...

bors · 2020-10-07T03:10:59Z

☀️ Test successful - checks-actions, checks-azure
Approved by: sfackler
Pushing 5779815 to master...

rust-log-analyzer · 2020-10-07T11:38:52Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-log-analyzer · 2020-10-07T11:43:52Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Clean up some of the pkgsrc Makefile, there's still lots in here that should just be deleted though. Switch SunOS to the illumos bootstrap by default. Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

Pkgsrc changes: * Compensate for files being moved around upstream. * Introduce optional, on-by-default semi-static building of cargo, using the internal curl and openssl sources. This reduces the dynamic dependencies of cargo and therefore the rust package itself. Ref. options.mk. * The 1.47.0 bootstrap kits have been re-built with the above option turned on, so no longer depends on curl or openssl from pkgsrc and/or from earlier OS or pkgsrc versions. This should hopefully fix installation of rust with non-default PREFIX, ref. PR#54453. Upstream changes: Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.] [77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

rust-highfive assigned LukasKalbertodt Jul 9, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2020

mbrubeck force-pushed the slice-eq branch from c8a37a6 to 910f461 Compare July 9, 2020 18:37

rust-highfive assigned sfackler and unassigned LukasKalbertodt Jul 12, 2020

mbrubeck force-pushed the slice-eq branch from 910f461 to 222e53a Compare July 28, 2020 14:36

Amanieu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 9, 2020

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Aug 9, 2020

mbrubeck force-pushed the slice-eq branch from 222e53a to 4b46200 Compare August 27, 2020 20:27

Add PartialEq impls for Vec <-> slice

b4b3839

mbrubeck force-pushed the slice-eq branch from 4b46200 to b4b3839 Compare August 27, 2020 20:33

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 16, 2020

pickfire reviewed Sep 17, 2020

View reviewed changes

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 26, 2020

rfcbot added the to-announce Announce this issue on triage meeting label Sep 26, 2020

spastorino removed the to-announce Announce this issue on triage meeting label Oct 1, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 6, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 7, 2020

bors merged commit 5779815 into rust-lang:master Oct 7, 2020

rustbot added this to the 1.49.0 milestone Oct 7, 2020

jplatte added a commit to jplatte/caniuse.rs that referenced this pull request Jan 15, 2021

Add rust-lang/rust#74194

4602c26

mbrubeck mentioned this pull request Jul 27, 2024

Add PartialEq impls to mirror the stdlib servo/rust-smallvec#358

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PartialEq impls for Vec <-> slice #74194

Add PartialEq impls for Vec <-> slice #74194

mbrubeck commented Jul 9, 2020 •

edited

Loading

rust-highfive commented Jul 9, 2020

mbrubeck commented Jul 9, 2020 •

edited

Loading

withoutboats commented Jul 9, 2020 •

edited

Loading

LukasKalbertodt commented Jul 12, 2020

bors commented Jul 28, 2020

mbrubeck commented Aug 1, 2020

Amanieu commented Aug 9, 2020

rfcbot commented Aug 9, 2020 •

edited by KodrAus

Loading

mbrubeck commented Aug 27, 2020

Dylan-DPC-zz commented Sep 16, 2020

rfcbot commented Sep 16, 2020

pickfire Sep 17, 2020

rfcbot commented Sep 26, 2020

sfackler commented Oct 6, 2020

bors commented Oct 6, 2020

bors commented Oct 6, 2020

bors commented Oct 6, 2020

mbrubeck commented Oct 6, 2020

bors commented Oct 6, 2020

Amanieu commented Oct 6, 2020

bors commented Oct 7, 2020

bors commented Oct 7, 2020

rust-log-analyzer commented Oct 7, 2020

rust-log-analyzer commented Oct 7, 2020

	($a2:expr, $a3:expr; $b2:expr, $b3: expr) => {
	($a2:expr,$a3:expr; $b2:expr,$b3: expr) => {

Add PartialEq impls for Vec <-> slice #74194

Add PartialEq impls for Vec <-> slice #74194

Conversation

mbrubeck commented Jul 9, 2020 • edited Loading

rust-highfive commented Jul 9, 2020

mbrubeck commented Jul 9, 2020 • edited Loading

withoutboats commented Jul 9, 2020 • edited Loading

LukasKalbertodt commented Jul 12, 2020

bors commented Jul 28, 2020

mbrubeck commented Aug 1, 2020

Amanieu commented Aug 9, 2020

rfcbot commented Aug 9, 2020 • edited by KodrAus Loading

mbrubeck commented Aug 27, 2020

Dylan-DPC-zz commented Sep 16, 2020

rfcbot commented Sep 16, 2020

pickfire Sep 17, 2020

Choose a reason for hiding this comment

rfcbot commented Sep 26, 2020

sfackler commented Oct 6, 2020

bors commented Oct 6, 2020

bors commented Oct 6, 2020

bors commented Oct 6, 2020

mbrubeck commented Oct 6, 2020

bors commented Oct 6, 2020

Amanieu commented Oct 6, 2020

bors commented Oct 7, 2020

bors commented Oct 7, 2020

rust-log-analyzer commented Oct 7, 2020

rust-log-analyzer commented Oct 7, 2020

mbrubeck commented Jul 9, 2020 •

edited

Loading

mbrubeck commented Jul 9, 2020 •

edited

Loading

withoutboats commented Jul 9, 2020 •

edited

Loading

rfcbot commented Aug 9, 2020 •

edited by KodrAus

Loading