Use exhaustive match in const_prop.rs #73693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Jun 24, 2020
| | Rvalue::Cast(..) | ||
| | Rvalue::Discriminant(..) | ||
| | Rvalue::AddressOf(..) | ||
| | Rvalue::NullaryOp(..) => {} |
There was a problem hiding this comment.
What is the justification for doing nothing for all of these?
I don't actually understand this code, maybe it would be better if @oli-obk reviewed this.^^
There was a problem hiding this comment.
Would be good to have a brief comment here saying why it is okay to ignore these.
RalfJung
reviewed
Jun 24, 2020
This comment has been minimized.
This comment has been minimized.
|
r? @oli-obk |
oli-obk
added
S-waiting-on-author
wesleywiser
force-pushed
the
const_prop_exhaustive_match
branch
from
e7920b2
to
b4d0457
Compare
|
Rebased and add a comment. |
|
@bors r+ |
|
📌 Commit b4d0457 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
|
⌛ Testing commit b4d0457 with merge 3f1a04d3651282e361fd66c2375f91a5ed78f1d6... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Looks like a networking issue or something? @bors r=oli-obk |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b4d0457 has been approved by |
bors
added
S-waiting-on-bors
|
The command to re-run CI is |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2020
…arth Rollup of 12 pull requests Successful merges: - rust-lang#73140 (Fallback to xml.etree.ElementTree) - rust-lang#73670 (Add `format_args_capture` feature) - rust-lang#73693 (Use exhaustive match in const_prop.rs) - rust-lang#73845 (Use &raw in A|Rc::as_ptr) - rust-lang#73861 (Create E0768) - rust-lang#73881 (Standardize bibliographic citations in rustc API docs) - rust-lang#73925 (Improve comments from rust-lang#72617, as suggested by RalfJung) - rust-lang#73949 ([mir-opt] Fix mis-optimization and other issues with the SimplifyArmIdentity pass) - rust-lang#73984 (Edit docs for rustc_data_structures::graph::scc) - rust-lang#73985 (Fix "getting started" link) - rust-lang#73997 (fix typo) - rust-lang#73999 (Bump mingw-check CI image from Ubuntu 16.04 to 18.04.) Failed merges: - rust-lang#74000 (add `lazy_normalization_consts` feature gate) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a comment left by @RalfJung on #73613
r? @RalfJung