Update Clippy #73660
Merged
Update Clippy #73660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo dev update lints use if_chain clean up alot, span_lint_and_sugg find imported macros for sugg
how to compare macro to import path add more imports to test
remove stdout, fix clippy warnings, fmtcar
Macro use sugg changelog: Add auto applicable suggstion to macro_use_imports fixes rust-lang#5275 <s>Where exactly is the `wildcard_imports_helper` I haven't been able to import anything ex. `use lazy_static;` or something like for that I get version/compiler conflicts?</s> Found it. Should we also check for `#[macro_use] extern crate`, although this is still depended on for stuff like `rustc_private`?
if_same_then_else: don't assume multiplication is always commutative changelog: Don't assume multiplication is always commutative in [`if_same_then_else`] Fixes rust-lang#5698
They're unused now.
…, r=dtolnay Migrate to numeric associated consts The deprecation PR is rust-lang#72885 cc rust-lang#68490 cc rust-lang/rfcs#2700
Fix typo changelog: extending it's lifetime -> extending its lifetime
Rollup of 9 pull requests Successful merges: - rust-lang#5178 (clippy-driver: pass all args to rustc if --rustc is present) - rust-lang#5705 (Downgrade unnested_or_patterns to pedantic) - rust-lang#5709 (Fix ICE in consts::binop) - rust-lang#5710 (typo) - rust-lang#5712 (Remove `bar` from blacklisted names) - rust-lang#5713 (Use lints in Clippy that are enabled in rustc bootstrap) - rust-lang#5716 (Fix typo in wildcard_imports) - rust-lang#5724 (redundant_pattern_matching: avoid non-`const fn` calls in const contexts) - rust-lang#5726 (Fix typo) Failed merges: r? @ghost changelog: rollup
Add more specific GitHub issue templates changelog: Make it easier to create feature request and bug reports with issue templates.
Improve end of expression check in for loop lints changelog: none
Remove unused allowed unused attributes changelog: none
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r=me but the CI seems unhappy (maybe transient?) |
|
This looks like a timeout or something? 🤔 |
|
@nikomatsakis CI passed now. Seems that it was just a hickup. |
|
@bors r+ |
|
📌 Commit a2c0499 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 |
|
☀️ Test successful - checks-azure |
Merged
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 14, 2020
Update Clippy ~~I'm not sure, if we can/should land this before beta is branched.~~ (Nvm, beta is already branched) The last Clippy update was 3 weeks ago: rust-lang#73660 This includes, besides other minor things: - New lints - One lint deprecation - One lint was moved to pedantic - Some FP fixes - I think an ICE fix? cc @Mark-Simulacrum r? @Manishearth --- We probably should also think of some process when and how often we should sync Clippy to the rust repo, so that we don't end up with those huge updates. Maybe every 2 weeks? Or even every week? cc @rust-lang/clippy
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 14, 2020
Update Clippy ~~I'm not sure, if we can/should land this before beta is branched.~~ (Nvm, beta is already branched) The last Clippy update was 3 weeks ago: rust-lang#73660 This includes, besides other minor things: - New lints - One lint deprecation - One lint was moved to pedantic - Some FP fixes - I think an ICE fix? cc @Mark-Simulacrum r? @Manishearth --- We probably should also think of some process when and how often we should sync Clippy to the rust repo, so that we don't end up with those huge updates. Maybe every 2 weeks? Or even every week? cc @rust-lang/clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.