Add license fields to all crates. #73530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updates src/tools/cargo. cc @ehuss |
rust-highfive
added
the
S-waiting-on-review
|
Discussion is ongoing https://rust-lang.zulipchat.com/#narrow/stream/231349-t-core.2Flicensing/topic/license.20fields.20to.20all.20rustc.20crates -- blocked on that resolving. |
Mark-Simulacrum
added
S-waiting-on-team
|
So, I wasn't sure this is the right syntax, so I checked: https://doc.rust-lang.org/stable/cargo/reference/manifest.html#the-license-and-license-file-fields Turns out my crates have been using the deprecated syntax. Fun! |
crlf0710
added
S-waiting-on-team
|
☔ The latest upstream changes (presumably #74662) made this pull request unmergeable. Please resolve the merge conflicts. |
crlf0710
force-pushed
the
name_the_charms
branch
from
03a42be
to
a283dad
Compare
|
Rebased. |
crlf0710
added
S-waiting-on-team
|
☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts. |
crlf0710
force-pushed
the
name_the_charms
branch
from
a283dad
to
e091547
Compare
crlf0710
force-pushed
the
name_the_charms
branch
from
e091547
to
54c787e
Compare
|
☔ The latest upstream changes (presumably #76558) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
ping from triage: status? |
crlf0710
added
S-waiting-on-team
crlf0710
added
S-waiting-on-team
|
I'm going to close this for now, as I think we're unlikely to reach an answer here quickly (certainly not this year, and likely not super early next) and in the meantime this is just going to accumulate merge conflicts and otherwise increase the passive workload in terms of the number of PRs open on this repository. I expect it to be fairly easy to reopen in the future (or recreate, if needed) once we have time to do this properly. |
est31
reviewed
Dec 7, 2020
| @@ -2,6 +2,7 @@ | |||
| authors = ["The Rust Project Developers"] | |||
| name = "rustc_apfloat" | |||
| version = "0.0.0" | |||
| license = "MIT OR Apache-2.0" | |||
There was a problem hiding this comment.
Can this be MIT OR Apache-2.0? It was fairly straightforwardly ported from the LLVM apfloat library. Maybe Apache 2.0 with llvm exception instead? SPDX License Identifier: "Apache-2.0 WITH LLVM-exception" according to https://llvm.org/foundation/relicensing/ .
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 18, 2021
Add license metadata for std dependencies These five crates are in the dependency tree of `std` but lack license metadata: - `alloc` - `core` - `panic_abort` - `panic_unwind` - `unwind` Querying the dependency tree of `std` is a useful thing to be able to do, since these crates will typically be linked into Rust binaries. Tools show the license fields missing, as seen in rust-lang#67014 (comment). This PR adds the license field for the five crates, based on the license of the `std` package and this repo as a whole. I also added the `repository` and `descriptions` fields, since those seem useful. For `description`, I copied text from top-level comments for the respective modules - except for `unwind` which has none. I also note that rust-lang#73530 attempted to add license metadata for all crates in this repo, but was rejected because there was question about some of them. I hope that this smaller change, focusing only on the runtime dependencies, will be easier to review. cc `@Mark-Simulacrum` `@Lokathor`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 19, 2021
Add license metadata for std dependencies These five crates are in the dependency tree of `std` but lack license metadata: - `alloc` - `core` - `panic_abort` - `panic_unwind` - `unwind` Querying the dependency tree of `std` is a useful thing to be able to do, since these crates will typically be linked into Rust binaries. Tools show the license fields missing, as seen in rust-lang#67014 (comment). This PR adds the license field for the five crates, based on the license of the `std` package and this repo as a whole. I also added the `repository` and `descriptions` fields, since those seem useful. For `description`, I copied text from top-level comments for the respective modules - except for `unwind` which has none. I also note that rust-lang#73530 attempted to add license metadata for all crates in this repo, but was rejected because there was question about some of them. I hope that this smaller change, focusing only on the runtime dependencies, will be easier to review. cc ``@Mark-Simulacrum`` ``@Lokathor``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 19, 2021
Add license metadata for std dependencies These five crates are in the dependency tree of `std` but lack license metadata: - `alloc` - `core` - `panic_abort` - `panic_unwind` - `unwind` Querying the dependency tree of `std` is a useful thing to be able to do, since these crates will typically be linked into Rust binaries. Tools show the license fields missing, as seen in rust-lang#67014 (comment). This PR adds the license field for the five crates, based on the license of the `std` package and this repo as a whole. I also added the `repository` and `descriptions` fields, since those seem useful. For `description`, I copied text from top-level comments for the respective modules - except for `unwind` which has none. I also note that rust-lang#73530 attempted to add license metadata for all crates in this repo, but was rejected because there was question about some of them. I hope that this smaller change, focusing only on the runtime dependencies, will be easier to review. cc ```@Mark-Simulacrum``` ```@Lokathor```
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 22, 2021
Add license metadata for std dependencies These five crates are in the dependency tree of `std` but lack license metadata: - `alloc` - `core` - `panic_abort` - `panic_unwind` - `unwind` Querying the dependency tree of `std` is a useful thing to be able to do, since these crates will typically be linked into Rust binaries. Tools show the license fields missing, as seen in rust-lang#67014 (comment). This PR adds the license field for the five crates, based on the license of the `std` package and this repo as a whole. I also added the `repository` and `descriptions` fields, since those seem useful. For `description`, I copied text from top-level comments for the respective modules - except for `unwind` which has none. I also note that rust-lang#73530 attempted to add license metadata for all crates in this repo, but was rejected because there was question about some of them. I hope that this smaller change, focusing only on the runtime dependencies, will be easier to review. cc `@Mark-Simulacrum` `@Lokathor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm playing with the
cargo-denytool and it reports that all these crates areunlicensed, so i figure maybe i can just add all of them.r? @Mark-Simulacrum