Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 16 pull requests #73528

Merged
merged 47 commits into from
Jun 20, 2020
Merged

Rollup of 16 pull requests #73528

merged 47 commits into from
Jun 20, 2020

Commits on May 28, 2020

  1. add str to common types

    lcnr committed May 28, 2020
    Configuration menu
    Copy the full SHA
    b3aa5e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Configuration menu
    Copy the full SHA
    df996e8 View commit details
    Browse the repository at this point in the history
  2. Add FIXME to comment regarding local patterns

    Co-authored-by: Bastian Kauschke <[email protected]>
    doctorn and lcnr authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    b4ddd91 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Diagnose use of incompatible sanitizers

    Emit an error when incompatible sanitizer are configured through command
    line options. Previously the last one configured prevailed and others
    were silently ignored.
    
    Additionally use a set to represent configured sanitizers, making it
    possible to enable multiple sanitizers at once. At least in principle,
    since currently all of them are considered to be incompatible with
    others.
    tmiasko committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    0a65f28 View commit details
    Browse the repository at this point in the history
  2. Improve Instance docs

    jonas-schievink committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    99d30da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9014df5 View commit details
    Browse the repository at this point in the history
  4. Remove Adjustment::DerefMove

    It does the same thing as `Deref` now
    jonas-schievink committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    26e17ae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58062e1 View commit details
    Browse the repository at this point in the history
  6. shim.rs: call FnPtr, not Self

    The `Call` terminator only works with `FnDef` and `FnPtr` types.
    It happened to work with `Self` so far because it was always
    substituted with the real type before being used.
    jonas-schievink committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    af97a11 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Add test

    jonas-schievink committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4cb26ad View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    5fbef22 View commit details
    Browse the repository at this point in the history
  2. bless all

    RalfJung committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    991dfe7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d1265e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e13935 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Configuration menu
    Copy the full SHA
    bde1ccf View commit details
    Browse the repository at this point in the history
  2. Add src/librustdoc as an alias for src/tools/rustdoc

    No one actually works with src/tools/librustdoc, it's almost empty.
    jyn514 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    936ecad View commit details
    Browse the repository at this point in the history
  3. Unify region variables when projecting associated types

    This is required to avoid cycles when evaluating auto trait
    predicates.
    matthewjasper committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    ba2ef58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f488dfc View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Configuration menu
    Copy the full SHA
    e9b0ce8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa11704 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. merge coercion test folders

    lcnr committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    0b5007e View commit details
    Browse the repository at this point in the history
  2. update coercion docs

    lcnr committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9b47586 View commit details
    Browse the repository at this point in the history
  3. coerce reborrow multi arg test

    lcnr committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    06a237f View commit details
    Browse the repository at this point in the history
  4. Bump Rustfmt and RLS

    Xanewok committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    f4b2a20 View commit details
    Browse the repository at this point in the history
  5. pretty/mir: const value enums with no variants

    This commit modifies the pretty printer and const eval in the MIR so
    that `destructure_const` (used in `pretty_print_const_value`) can handle
    enums with no variants (or types containing enums with no variants).
    
    Signed-off-by: David Wood <[email protected]>
    davidtwco committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    6fa7dc6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2f9d338 View commit details
    Browse the repository at this point in the history
  7. update tests

    pvdrz committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    014e605 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1f48465 View commit details
    Browse the repository at this point in the history
  9. add new error code

    pvdrz committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    96031e2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8f0bd5f View commit details
    Browse the repository at this point in the history
  11. Refactor try_find a little

    The `E` type parameter was unnecessary, so it's now removed. The folding
    closure now has reduced parametricity on just `T = Self::Item`, rather
    than the whole `Self` iterator type. There's otherwise no functional
    change in this.
    cuviper committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    db0d70e View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Rollup merge of rust-lang#71420 - RalfJung:specialization-incomplete,…

    … r=matthewjasper
    
    Specialization is unsound
    
    As discussed in rust-lang#31844 (comment), it might be a good idea to warn users of specialization that the feature they are using is unsound.
    
    I also expanded the "incomplete feature" warning to link the user to the tracking issue.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    203305d View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#71899 - cuviper:try_find_map, r=dtolnay

    Refactor `try_find` a little
    
    ~~This works like `find_map`, but mapping to a `Try` type. It stops when `Ok` is `Some(value)`, with an additional short-circuit on `Try::Error`. This is similar to the unstable `try_find`, but has the advantage of being able to directly return the user's `R: Try` type directly, rather than converting to `Result`.~~
    (removed -- `try_find_map` was declined in review)
    
    This PR also refactors `try_find` a little to match style. The `E` type parameter was unnecessary, so it's now removed. The folding closure now has reduced parametricity on just `T = Self::Item`, rather
    than the whole `Self` iterator type. There's otherwise no functional change in this.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    5c9cd82 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#72689 - lcnr:common_str, r=estebank

    add str to common types
    
    I already expected this to be the case and it may slightly improve perf.
    
    Afaict if we ever want to change str into a lang item this would have to get reverted.
    As that would be fairly simple I don't believe this to cause any problems in the future.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    218b90f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72791 - lcnr:coerce-refactor, r=estebank

    update coerce docs and unify relevant tests
    
    Merges `test/ui/coerce` with `test/ui/coercion`.
    Updates the documentation of `librustc_typeck/check/coercion.rs`.
    Adds 2 new coercion tests.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    c0a25be View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72934 - christianpoveda:mut-borrows-in-cons…

    …ts, r=oli-obk
    
    forbid mutable references in all constant contexts except for const-fns
    
    PR to address rust-lang#71212
    
    cc: @ecstatic-morse
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    dac512e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73027 - doctorn:issue-72690, r=estebank

    Make `need_type_info_err` more conservative
    
    Makes sure arg patterns we are going to suggest on are actually contained within the span of the obligation that caused the inference error (credit to @lcnr for suggesting this fix).
    
    There's a subtle trade-off regarding the handling of local patterns which I've left a comment about.
    
    Resolves rust-lang#72690
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    2d1bd57 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73347 - tmiasko:incompatible-sanitizers, r=…

    …nikic
    
    Diagnose use of incompatible sanitizers
    
    Emit an error when incompatible sanitizer are configured through command
    line options. Previously the last one configured prevailed and others
    were silently ignored.
    
    Additionally use a set to represent configured sanitizers, making it
    possible to enable multiple sanitizers at once. At least in principle,
    since currently all of them are considered to be incompatible with
    others.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    17b80d9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73359 - jonas-schievink:do-the-shimmy, r=ma…

    …tthewjasper
    
    shim.rs: avoid creating `Call` terminators calling `Self`
    
    Also contains some cleanup and doc comment additions so I could make sense of the code.
    
    Fixes rust-lang#73109
    Closes rust-lang#73175
    
    r? @matthewjasper
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    fe4b485 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73399 - GuillaumeGomez:cleanup-e0668, r=Dyl…

    …an-DPC
    
    Clean up E0668 explanation
    
    r? @Dylan-DPC
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    2dbb8b6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73436 - GuillaumeGomez:cleanup-e0670, r=Dyl…

    …an-DPC
    
    Clean up E0670 explanation
    
    r? @Dylan-DPC
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    2377a50 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#73440 - jyn514:bootstrap/build-rustdoc, r=M…

    …ark-Simulacrum
    
    Add src/librustdoc as an alias for src/tools/rustdoc
    
    No one actually works with src/tools/rustdoc, it's almost empty.
    
    Closes rust-lang#73439
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    d69d4c3 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#73442 - davidtwco:issue-72181-pretty-print-…

    …const-val-enum-no-variants, r=oli-obk
    
    pretty/mir: const value enums with no variants
    
    Fixes rust-lang#72181.
    
    This PR modifies the pretty printer and const eval in the MIR so that `destructure_const` (used in `pretty_print_const_value`) can handle enums with no variants (or types containing enums with no variants).
    
    I'm not convinced that this is the correct approach, folks more familiar with `destructure_const` would be able to say - happy to adjust the PR. Looking through `destructure_const` and the functions that it invokes, it didn't seem like it was written to handle zero-variant-enums - I assume that case is handled earlier in some way so `destructure_const` doesn't need to under normal circumstances. It didn't seem like it would be straightforward to make `destructure_const` handle this case in a first-class-feeling way (e.g. adding a `Variants::None` variant), so this PR makes some minimal changes to avoid ICEs.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    db7203d View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#73452 - matthewjasper:auto-rec, r=nikomatsakis

    Unify region variables when projecting associated types
    
    This is required to avoid cycles when evaluating auto trait predicates.
    Notably, this is required to be able add Chalk types to `CtxtInterners` for `cfg(parallel_compiler)`.
    
    r? @nikomatsakis
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    61f8c3e View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#73458 - tmiasko:arena-layout, r=matthewjasper

    Use alloc::Layout in DroplessArena API
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    fd1c783 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#73484 - poliorcetics:use-prelude-doc, r=sfa…

    …ckler
    
    Update the doc for std::prelude to the correct behavior
    
    Fixes rust-lang#64686.
    
    One line change to ensure the docs are correct about the behavior of the compiler when inserting`std::prelude::v1`.
    
    I don't think examples are necessary but I can add some (especially those from the original issue) if needed.
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    7777b0b View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#73506 - Xanewok:update-rls, r=Xanewok

    Bump Rustfmt and RLS
    
    Fixes rust-lang#73406
    Fixes rust-lang#73199
    Fixes rust-lang#73407
    Fixes rust-lang#73200
    
    cc @calebcartwright @topecongiro
    
    r? @ghost
    
    Let's see what CI says first
    Manishearth authored Jun 20, 2020
    Configuration menu
    Copy the full SHA
    3e40cca View commit details
    Browse the repository at this point in the history