resolve: report duplicate-module errors #7325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmr Any idea what happened? The compile error seems to be completely unrelated to the change. |
|
@artagnon unfortunately the buildbot seems to be a bit eccentric right now. Only one build failed, and it was a test failure: So, gotta go in and fix that one. |
add_child() is responsible for reporting errors about type, value, and
module duplicate definitions. Although it checks for all three, it uses
namespace_to_str() to convert a Namespace value into a string before
printing an error like:
error: duplicate definition of type `foo`
^^^^
note: first definition of type foo here:
^^^^
Unfortunately, this string can only be one of "type" or
"value" (corresponding to TypeNS and ValueNS respectively), and it
reports duplicate modules as duplicate types.
To alleviate the problem, define a special NamespaceError enum to define
more specialized errors, and use it instead of attempting to reuse the
Namespace enum.
Reported-by: Corey Richardson <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
The "first definition of ..." error string reported by add_child() looks different from similar messages reported by other functions. Fix this. Signed-off-by: Ramkumar Ramachandra <[email protected]>
|
@cmr Thanks for digging it out. But I still didn't understand what the failure is: it was expected to compile-fail, and it actually did compile-fail; or did it try to compare the actual error message with that comment (?) string? |
|
@artagnon Yes, it compares to the exact error message in the comment. It's a way to make sure we don't break or remove error messages. |
|
@cmr Okay, thanks. Can you re-approve the new version? |
bors
added a commit
that referenced
this pull request
Jun 25, 2013
Fix #7322. I started out with a band-aid approach to special-case the duplicate module error using `is_duplicate_module`, but thought this would be better in the long term.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 17, 2021
Fix FP in `default_numeric_fallback` with external macro expansion fixes rust-lang#7304 changelog: Fix `default_numeric_fallback` FP with external macro expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7322.
I started out with a band-aid approach to special-case the duplicate module error using
is_duplicate_module, but thought this would be better in the long term.