Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] perf only: disable default MIR validation #73087

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] perf only: disable default MIR validation #73087

wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 7, 2020

Let's see if the MIR validation we have so far has any measurable perf impact.

Cc @jonas-schievink

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2020
@RalfJung
Copy link
Member Author

RalfJung commented Jun 7, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jun 7, 2020

⌛ Trying commit 8a6cb26 with merge 6a562464d19b3a8b4c4fa14568181baa66e4197c...

@bors
Copy link
Contributor

bors commented Jun 7, 2020

☀️ Try build successful - checks-azure
Build commit: 6a562464d19b3a8b4c4fa14568181baa66e4197c (6a562464d19b3a8b4c4fa14568181baa66e4197c)

@rust-timer
Copy link
Collaborator

Queued 6a562464d19b3a8b4c4fa14568181baa66e4197c with parent 450abe8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6a562464d19b3a8b4c4fa14568181baa66e4197c): comparison url.

@RalfJung
Copy link
Member Author

RalfJung commented Jun 8, 2020

Looks like indeed this is insignificant. Good to know.

Cc @nnethercote -- just FYI.

@RalfJung RalfJung closed this Jun 8, 2020
@RalfJung RalfJung deleted the mir-validation-perf branch June 8, 2020 10:26
@RalfJung RalfJung mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rust-highfive @rust-timer @bors @eddyb