Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bootstrap compiler to 1.45 #72957

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Bump bootstrap compiler to 1.45 #72957

merged 1 commit into from
Jun 5, 2020

Conversation

Mark-Simulacrum
Copy link
Member

Pretty standard update.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2020
@Mark-Simulacrum
Copy link
Member Author

cc @rust-lang/clippy on https://github.com/rust-lang/rust/pull/72957/files#diff-e650e88617b30d8d2157e23c9dcc5286L282 which is technically a behavior change

@sfackler
Copy link
Member

sfackler commented Jun 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 3, 2020

📌 Commit 7139342 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2020
@camelid
Copy link
Member

camelid commented Jun 3, 2020

By the way, the title of this PR is "Bump bootstrap compiler to 1.45" whereas it's actually bumped to 1.46, unless I'm misunderstanding

@Mark-Simulacrum
Copy link
Member Author

No, the new compiler is versioned at 1.46 but the beta compiler used to bootstrap is 1.45 I believe.

@camelid
Copy link
Member

camelid commented Jun 3, 2020

Ah, sorry :). It just confused me because your commit said 1.46 but the PR said 1.45

@flip1995
Copy link
Member

flip1995 commented Jun 3, 2020

This was also already fixed in Clippy, in semantically the same way: rust-lang/rust-clippy@37381d3#diff-2e8e94b55639a4808cb93bcc616d2d92

Thanks for the heads-up 👍

@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Jun 5, 2020

⌛ Testing commit 7139342 with merge d1df548ba0d29cbbc588f786ea78f3a8503d05c6...

@bors
Copy link
Contributor

bors commented Jun 5, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2020
@Dylan-DPC-zz
Copy link

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2020
@bors
Copy link
Contributor

bors commented Jun 5, 2020

⌛ Testing commit 7139342 with merge 84ec823...

@bors
Copy link
Contributor

bors commented Jun 5, 2020

☀️ Test successful - checks-azure
Approved by: sfackler
Pushing 84ec823 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2020
@bors bors merged commit 84ec823 into rust-lang:master Jun 5, 2020
This was referenced Jun 5, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mark-Simulacrum @rust-highfive @sfackler @bors @camelid @flip1995 @Dylan-DPC-zz