vec: remove BaseIter implementation #7289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the `static-method-test.rs` test because it was heavily based on `BaseIter` and there are plenty of other more complex uses of static methods anyway.
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 17, 2021
…Manishearth Fix needless_collect with binding shadowing changelog: Fix [`needless_collect`] weird output when a binding is shadowed Fixes rust-lang#7200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
static-method-test.rstest because it was heavily basedon
BaseIterand there are plenty of other more complex uses of staticmethods anyway.
This is a huge step towards being able to implement a new
forloop but it's going to be a bit of a pain to land... The vast majority offorloops now use external iterators.