normalize field projection ty to fix broken MIR issue #71488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Apr 27, 2020
| @@ -686,6 +686,7 @@ impl<'a, 'b, 'tcx> TypeVerifier<'a, 'b, 'tcx> { | |||
| let fty = self.sanitize_type(place, fty); | |||
| match self.field_ty(place, base, field, location) { | |||
There was a problem hiding this comment.
Is field_ty used in more places? Do those places normalize too? Maybe it would be good to normalize inside field_ty itself.
There was a problem hiding this comment.
That seems to be the only call to that field_ty. There's another call with normalization that happens here but that calls this field_ty.
There was a problem hiding this comment.
btw, I can move both normalize calls inside field_ty if you prefer.
|
@bors r+ |
|
📌 Commit 7bafb57 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71311 (On `FnDef` type annotation suggestion, use fn-pointer output) - rust-lang#71488 (normalize field projection ty to fix broken MIR issue) - rust-lang#71489 (Fix off by one in treat err as bug) - rust-lang#71585 (remove obsolete comment) - rust-lang#71634 (Revert rust-lang#71372 ("Fix #! (shebang) stripping account space issue").) Failed merges: r? @ghost
LeSeulArtichaut
added
the
beta-nominated
spastorino
added
the
T-compiler
|
(deleted comment that was posted on incorrect issue) |
pnkfelix
added
beta-accepted
|
(OMG I posted on the wrong issue) |
pnkfelix
removed
I-nominated
beta-accepted
|
discussed at this week's T-compiler meeting beta-accepted |
pnkfelix
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2020
…ulacrum [beta] backports This backport rollup includes the following: * [beta] Update cargo rust-lang#71967 * Backport 1.43.1 release notes to master rust-lang#71914 * Update the `cc` crate rust-lang#71882 * resolve: Relax fresh binding disambiguation slightly to fix regression rust-lang#71846 * Do not try to find binop method on RHS `TyErr` rust-lang#71810 * Quick and dirty fix of the unused_braces lint rust-lang#71517 * Update stdarch submodule rust-lang#71495 * normalize field projection ty to fix broken MIR issue rust-lang#71488 * Update openssl-src to 1.1.1g rust-lang#71430 * fix error code in E0751.md rust-lang#71426 * Don't fuse Chain in its second iterator rust-lang#71404 * Remove some `Vec` allocations to improve performance rust-lang#71268 * [CI] Use the latest Python available on Windows rust-lang#71995 It also switches the bootstrap compiler to 1.43.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71344
r? @eddyb