Remove unused abs_path method from rustc_span::source_map::FileLoader #71263
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
I noticed this was unused, but I'm not sure if we want to keep it around for compatibility or not. |
shlevy
force-pushed
the
FileLoader-remove-abs_path
branch
from
2b8faca
to
c7899a0
Compare
|
FWIW it's used by the RLS but the function is so trivial I'd be fine with removing this (in fact it is even reimplemented in the ipc bridge for of the RLS). |
|
@Xanewok Looks like it's only used to implement the method itself in a wrapper? 🙂 |
|
📌 Commit c7899a0 has been approved by |
bors
added
S-waiting-on-bors
…r=Xanewok Remove unused abs_path method from rustc_span::source_map::FileLoader
|
probably breaking rls in the rollup @bors r- |
bors
added
S-waiting-on-author
|
Is this no-breakage week for tools already? |
|
Yep |
|
Sorry, does this mean we can't do this removal at all, or just that we have to wait a week? If we can't remove it, can we mark it deprecated/unused? |
|
@shlevy just have to wait a week :) |
|
@Xanewok @Dylan-DPC Good to move forward? |
|
I believe so, thanks @bors r+ |
|
📌 Commit c7899a0 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - rust-lang#68716 (Stabilize `Span::mixed_site`) - rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader) - rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`) - rust-lang#71419 (add message for resolution failure because wrong namespace) - rust-lang#71438 (Tweak some suggestions in `rustc_resolve`) - rust-lang#71589 (remove Unique::from for shared pointer types) Failed merges: r? @ghost
Breakage caused by rust-lang#71263.
Update RLS to unbreak toolstate Breakage caused by rust-lang#71263. r? @ghost
No description provided.