Don't use the HirId to NodeId map in MIR #71197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
LGTM, I asked a clarifying question above, but that doesn't need to block this PR. @bors r+ |
|
📌 Commit 672b768 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r+ |
|
📌 Commit 66575c9 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70611 (Add long error explanation for E0708 rust-lang#61137) - rust-lang#71197 (Don't use the HirId to NodeId map in MIR) - rust-lang#71211 (Update cargo) - rust-lang#71219 (Minor fixes to doc comments of 'VecDeque') - rust-lang#71221 (Dogfood or_patterns in rustdoc) Failed merges: r? @ghost
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 20, 2020
…d_mir, r=ecstatic-morse MIR: use HirId instead of NodeId to avoid cycles while inlining I wanted to see if I could limit the number of uses of `NodeId` when `HirId` is available and I saw that some of the MIR `Inliner` code could use `Span` instead of `NodeId`, not unlike in rust-lang#71197. ~If I'm understanding the reason for not calling `optimized_mir` in incremental builds here correctly, this change could also allow us to do so.~ This change could affect performance, so if this approach makes sense, a perf run is probably a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards not having to build a
HirIdtoNodeIdmap other than for doc and RLS purposes.We are currently sorting
unsafeblocks byNodeIdincheck_unsafety; change it to sorting bySpaninstead; this passes the tests, but better ideas are welcome.In addition, simplify the split between the used and unused
unsafeblocks for readability and less sorting.cc #50928