-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial work on building with Cargo #71029
Changes from all commits
45ede92
ac2b84f
53d58db
3dd500d
1864caa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,8 +26,6 @@ | |
|
||
#[macro_use] | ||
extern crate log; | ||
#[cfg(unix)] | ||
extern crate libc; | ||
#[macro_use] | ||
extern crate cfg_if; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ hermit-abi = { version = "0.1.10", features = ['rustc-dep-of-std'] } | |
wasi = { version = "0.9.0", features = ['rustc-dep-of-std'], default-features = false } | ||
|
||
[features] | ||
default = ["std_detect_file_io", "std_detect_dlsym_getauxval"] | ||
default = ["std_detect_file_io", "std_detect_dlsym_getauxval", "panic-unwind"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is somewhat surprising to me, what's the explanation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to link to some panic runtime for std to build and I believe bootstrap always builds std with panic-unwind linked in today. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't this negatively affect some |
||
|
||
backtrace = [ | ||
"backtrace_rs/dbghelp", # backtrace/symbolize on MSVC | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this broke rustfmt and rls in #71059 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right link-related
extern crate
s still exist in rustc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems likely, but I'm pretty sure that once y'all bump the autopublished librustc_session crate then things should work. If not, please do let me know, we can re-add this here as needed.