Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take impl Into<DefId> for query methods on TyCtxt #70961

Merged
merged 8 commits into from
Apr 13, 2020
Merged

Take impl Into<DefId> for query methods on TyCtxt #70961

merged 8 commits into from
Apr 13, 2020

Commits on Apr 11, 2020

  1. Make query helpers on TyCtxt take impl Into<DefId>

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    62b5aff View commit details
    Browse the repository at this point in the history

  2. Impl From<LocalDefId> for DefId

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    10ed501 View commit details
    Browse the repository at this point in the history

  3. Fix inference fallout

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    0d4639d View commit details
    Browse the repository at this point in the history

  4. Remove call to to_def_id before calling query helper

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    6e5a210 View commit details
    Browse the repository at this point in the history

  5. Simplify macro

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    fd8cf3c View commit details
    Browse the repository at this point in the history

  6. Use custom trait instead of Into

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    beeacdb View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from review

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    f0c7733 View commit details
    Browse the repository at this point in the history

  8. Add #[inline(always)] to into_query_param

    @ecstatic-morse
    ecstatic-morse committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    04c91a0 View commit details
    Browse the repository at this point in the history