Don't import integer and float modules, use assoc consts #70777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit fc8caffcba72bf80b89c2585f0394bf32ecfe8f5 has been approved by |
bors
added
the
S-waiting-on-bors
|
I don't think the CI error is caused by me(?) |
|
failure seems to be related to #69898 |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Can we run this again now that the breaking PR has been fixed? |
|
@bors retry |
faern
force-pushed
the
use-assoc-int-consts2
branch
from
fc8caff
to
101085a
Compare
|
I of course had to rebase it to fix the build issue as well... I somehow expected Bors to merge my branch with master and then try that automatically.. |
|
📌 Commit 101085a has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#67797 (Query-ify Instance::resolve) - rust-lang#70777 (Don't import integer and float modules, use assoc consts) - rust-lang#70795 (Keep track of position when deleting from a BTreeMap) - rust-lang#70812 (Do not use "nil" to refer to `()`) - rust-lang#70815 (Enable layout debugging for `impl Trait` type aliases) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 7, 2020
…=dtolnay Don't import integer and float modules, use assoc consts 2 Follow up to rust-lang#70777. I missed quite a lot of places. Partially because I wanted to keep the size of the last PR down, and partially because my regexes were not good enough :) r? @dtolnay
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 7, 2020
…=dtolnay Don't import integer and float modules, use assoc consts 2 Follow up to rust-lang#70777. I missed quite a lot of places. Partially because I wanted to keep the size of the last PR down, and partially because my regexes were not good enough :) r? @dtolnay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop importing the standard library integer and float modules to reach the
MIN,MAXand other constants. They are available directly on the primitive types now.This PR is a follow up of #69860 which made sure we use the new constants in documentation.
This type of change touches a lot of files, and previously all my assoc int consts PRs had collisions and were accepted only after a long delay. So I'd prefer to do it in smaller steps now. Just removing these imports seem like a good next step.
r? @dtolnay