Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustdoc] Improve visibility for code blocks warnings #70005

Merged
merged 2 commits into from
Mar 19, 2020
Merged

[rustdoc] Improve visibility for code blocks warnings #70005

merged 2 commits into from
Mar 19, 2020

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 14, 2020 •
edited
Loading

It appeared that a lot of people didn't notice when a code block was meant to fail compilation or wasn't tested at all. The changes here make the colors less transparent and the icon bigger. So before it looked like this:

old-light
old-dark

And now it looks like this:

new-light
new-dark

cc @rust-lang/rustdoc
r? @kinnison

@GuillaumeGomez GuillaumeGomez changed the title Code block signs [rustdoc] Improve visibility for code blocks warnings Mar 14, 2020
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2020
@kinnison
Copy link
Contributor

@GuillaumeGomez There appear to be a few cases of changes in there which (for example) change black for #000 -- is there a reason you did that in a change supposedly just about improving the visibility of the code block warnings? If you have good reason then r=me otherwise please could you rebase to remove the extraneous CSS changes so that only the changes needed for this fix are in the commits?

@kinnison kinnison added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2020
@GuillaumeGomez
Copy link
Member Author

Didn't pay attention to that. #000 and black are the same. I guess it comes from copying/pasting values from the web browser, my bad. Do you want me to revert them? They're basically the same after all...

@Kixiron Kixiron added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2020
@kinnison
Copy link
Contributor

From a commit hygiene perspective I'd prefer the non-related changes not be there, but I am aware that commit hygiene isn't quite as mandatory in this codebase, so it's your call. If you agree it's better to remove them then do so, if not then don't. Either way you can r=kinnison when you've decided.

@kinnison kinnison added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2020
@GuillaumeGomez
Copy link
Member Author

Sorry but I think I'll keep it as is. The code looks a bit simpler to me like this. Thanks for your review!

@bors: r=kinnison

@bors
Copy link
Contributor

bors commented Mar 17, 2020

📌 Commit 8216a32 has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2020
@Centril
Rollup merge of rust-lang#70005 - GuillaumeGomez:code-block-signs, r=…
610c7a5 
…kinnison

[rustdoc] Improve visibility for code blocks warnings

It appeared that a lot of people didn't notice when a code block was meant to fail compilation or wasn't tested at all. The changes here make the colors less transparent and the icon bigger. So before it looked like this:

![old-light](https://user-images.githubusercontent.com/3050060/76687070-f1cdbb80-6620-11ea-9b73-0c787dc671f7.png)
![old-dark](https://user-images.githubusercontent.com/3050060/76687079-f4c8ac00-6620-11ea-90fb-e548329e01b4.png)

And now it looks like this:

![new-light](https://user-images.githubusercontent.com/3050060/76687092-fd20e700-6620-11ea-9ebb-2b6852f00899.png)
![new-dark](https://user-images.githubusercontent.com/3050060/76687091-fd20e700-6620-11ea-8fea-6854c8367b97.png)

cc @rust-lang/rustdoc
r? @kinnison
@Centril Centril mentioned this pull request Mar 19, 2020
Closed
bors added a commit that referenced this pull request Mar 19, 2020
@bors
Auto merge of #70130 - Centril:rollup-8hk2y7z, r=Centril
4d404b3 
Rollup of 9 pull requests

Successful merges:

 - #69036 (rustc: don't resolve Instances which would produce malformed shims.)
 - #69443 (tidy: Better license checks.)
 - #69814 (Smaller and more correct generator codegen)
 - #69929 (Regenerate tables for Unicode 13.0.0)
 - #69959 (std: Don't abort process when printing panics in tests)
 - #69969 (unix: Set a guard page at the end of signal stacks)
 - #70005 ([rustdoc] Improve visibility for code blocks warnings)
 - #70088 (Use copy bound in atomic operations to generate simpler MIR)
 - #70095 (Implement -Zlink-native-libraries)

Failed merges:

r? @ghost
@Centril Centril mentioned this pull request Mar 19, 2020
Merged
bors added a commit that referenced this pull request Mar 19, 2020
@bors
Auto merge of #70132 - Centril:rollup-oe8unsn, r=Centril
6724d58 
Rollup of 9 pull requests

Successful merges:

 - #68941 (Properly handle Spans that reference imported SourceFiles)
 - #69036 (rustc: don't resolve Instances which would produce malformed shims.)
 - #69443 (tidy: Better license checks.)
 - #69814 (Smaller and more correct generator codegen)
 - #69929 (Regenerate tables for Unicode 13.0.0)
 - #69959 (std: Don't abort process when printing panics in tests)
 - #69969 (unix: Set a guard page at the end of signal stacks)
 - #70005 ([rustdoc] Improve visibility for code blocks warnings)
 - #70088 (Use copy bound in atomic operations to generate simpler MIR)

Failed merges:

r? @ghost
@bors bors merged commit 637233d into rust-lang:master Mar 19, 2020
@GuillaumeGomez GuillaumeGomez deleted the code-block-signs branch March 19, 2020 11:03
@SimonSapin SimonSapin mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kinnison kinnison

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @kinnison @bors @JohnTitor @Kixiron