Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: update clippy from 8b7f7e66 to 74eae9dc #69692

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

matthiaskrgr
Copy link
Member

Changes:

Rustup to rust-lang/rust#69506
Revive rls integration test
use question mark operator
Add regression test
Use `try_eval_usize` over `eval_usize`
Add path for display trait
Use lang items instead of get_trait_def_id where possible
Update stderr
Don't lint debug formatting in debug impl
Whitelist unused attribute for use items.
add test for #5238

Makes clippy tests pass again.

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Mar 4, 2020

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 4, 2020

📌 Commit a7724c7 has been approved by oli-obk

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 4, 2020
@bors
Copy link
Contributor

bors commented Mar 4, 2020

⌛ Testing commit a7724c7 with merge 39b4331...

bors added a commit that referenced this pull request Mar 4, 2020
submodules: update clippy from 8b7f7e6 to 74eae9d

Changes:
````
Rustup to #69506
Revive rls integration test
use question mark operator
Add regression test
Use `try_eval_usize` over `eval_usize`
Add path for display trait
Use lang items instead of get_trait_def_id where possible
Update stderr
Don't lint debug formatting in debug impl
Whitelist unused attribute for use items.
add test for #5238
````

Makes clippy tests pass again.

r? @oli-obk
@bors
Copy link
Contributor

bors commented Mar 4, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2020
Changes:
````
Apply suggestions from code review
Simplify if_chain.
Move NumericLiteral to its own module.
Included binary and octal cases.
Resolve false positives for hex int cast.
Test for unnecessary_cast of hex int literal.
run-rustfix
Lint `if let Some` in question_mark lint
Add restrictive pat use in full binded struct
Update test case answers to match cargo dev fmt
Ran cargo dev fmt
Rustup to rust-lang#69506
Recommended changes from flip1995
Revive rls integration test
use question mark operator
Add regression test
Use `try_eval_usize` over `eval_usize`
Add path for display trait
Use lang items instead of get_trait_def_id where possible
Update stderr
Don't lint debug formatting in debug impl
Whitelist unused attribute for use items.
Fix one last test issue
Refactor suggested by krishna-veerareddy
Fixed compile error from merging
Changed test output to reflect cargo fmt
Run cargo dev fmt
Finished checking for cases of absolute values
add test for rust-lang#5238
Some bugfixing
Created floating point abs lint and test, but not yet run
````
@matthiaskrgr
Copy link
Member Author

Needs retry.
I've updated the submodule to contain some more recent commits again.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 5, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2020

📌 Commit c3bceb1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
@bors
Copy link
Contributor

bors commented Mar 5, 2020

⌛ Testing commit c3bceb1 with merge c79f5f0...

@bors
Copy link
Contributor

bors commented Mar 5, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing c79f5f0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 5, 2020
@bors bors merged commit c79f5f0 into rust-lang:master Mar 5, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #69692!

Tested on commit c79f5f0.
Direct link to PR: #69692

🎉 clippy-driver on windows: test-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: test-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 5, 2020
Tested on commit rust-lang/rust@c79f5f0.
Direct link to PR: <rust-lang/rust#69692>

🎉 clippy-driver on windows: test-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: test-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants