Clean up TypeFlags #69469
Merged
Clean up TypeFlags #69469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r=me with travis |
|
@bors r=cramertj |
|
📌 Commit df3bd258a562fec3e8d44ab261342d1c1741945c has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #69612) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
* Add a new method `has_infer_types_or_consts` that's used instead most of the time, since there's generally no reason to only consider types. * Remove use of `has_closure_types`, because closures are no longer implicitly linked to the `InferCtxt`.
* Reorder flags to group similar ones together * Make some flags more granular * Compute `HAS_FREE_LOCAL_NAMES` from the other flags * Remove `HAS_TY_CLOSURE` * Add some more doc comments
matthewjasper
force-pushed
the
type-flags
branch
from
df3bd25
to
1617ec4
Compare
|
@bors r=cramertj |
|
📌 Commit 1617ec4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Merged
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Mar 2, 2020
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Mar 2, 2020
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Mar 2, 2020
Rustup to rust-lang/rust#69469 changelog: none
bors
added a commit
that referenced
this pull request
Mar 2, 2020
Update cargo, clippy Closes #69601 ## cargo 16 commits in e57bd02999c9f40d52116e0beca7d1dccb0643de..bda50510d1daf6e9c53ad6ccf603da6e0fa8103f 2020-02-21 20:20:10 +0000 to 2020-03-02 18:05:34 +0000 - Fix rare failure in collision_export test. (rust-lang/cargo#7956) - Ignore broken Cargo.toml in git sources (rust-lang/cargo#7947) - Add more fingerprint mtime debug logging. (rust-lang/cargo#7952) - Fix plugin tests for latest nightly. (rust-lang/cargo#7955) - Simplified usage code of SipHasher (rust-lang/cargo#7945) - Add a special case for git config discovery inside tests (rust-lang/cargo#7944) - Fixes issue rust-lang/cargo#7543 (rust-lang/cargo#7946) - Filter out cfgs which should not be used during build (rust-lang/cargo#7943) - Provide extra context on a query failure. (rust-lang/cargo#7934) - Try to clarify `cargo metadata`'s relationship with the workspace. (rust-lang/cargo#7927) - Update libgit2 dependency (rust-lang/cargo#7939) - Fix link in comment (rust-lang/cargo#7936) - Enable `cargo doc --open` tests on macos. (rust-lang/cargo#7932) - build-std: remove sysroot probe (rust-lang/cargo#7931) - Try to clarify how feature flags work on the "current" package. (rust-lang/cargo#7928) - Add extra details in the new feature resolver doc comment. (rust-lang/cargo#7918) ## clippy 6 commits in fc5d0cc..8b7f7e6 2020-02-24 05:58:17 +0000 to 2020-03-02 20:00:31 +0000 - Rustup to #69469 (rust-lang/rust-clippy#5254) - Some rustups (rust-lang/rust-clippy#5247) - Update git2 to 0.12 (rust-lang/rust-clippy#5232) - Rustup to #61812 (rust-lang/rust-clippy#5231) - Add lint to improve floating-point expressions (rust-lang/rust-clippy#4897) - Do not run deploy action on other repos (rust-lang/rust-clippy#5222)
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 17, 2020
…ikomatsakis Ensure HAS_FREE_LOCAL_NAMES is set for ReFree This fixes a bug introduced by rust-lang#69469. I don't have any ideas on how to reate a regression test for this.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 17, 2020
…ikomatsakis Ensure HAS_FREE_LOCAL_NAMES is set for ReFree This fixes a bug introduced by rust-lang#69469. I don't have any ideas on how to reate a regression test for this.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 17, 2020
…ikomatsakis Ensure HAS_FREE_LOCAL_NAMES is set for ReFree This fixes a bug introduced by rust-lang#69469. I don't have any ideas on how to reate a regression test for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has_infer_types_or_conststhat's used instead ofhas_infer_typesmost of the time, since there's generally no reason to only consider types.has_closure_types/HAS_TY_CLOSURE, because closures are no longer implicitly linked to theInferCtxt.HAS_FREE_LOCAL_NAMESfrom the other flags