rustc::middle::trans::reachable: remove some unneeded code #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed a fix (hopefully). |
|
This needed a rebase, which I've pushed now. |
This was a remnant from the export list era.
|
Pushed a rebase and fixed the last failing test. |
|
Hmm, the failure doesn't look related. In fact, it's the same one as in #7035, where it also doesn't look related. |
|
In fact, when looking at the code around the triggered assertion, it looks like this is caused by running the rustpkg tests in parallel and tripping over LLVM global data. Hopefully #7040 clears this up. |
|
Looking into this a little bit more, it looks like LLVM will have to be recompiled with |
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 25, 2021
…nDefault, r=Manishearth Fix suggestion with generics for `field_reassign_with_default` lint Fix bad suggestion where `::` is missing after type if generics are involved Fixes rust-lang#6944 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a remnant from the export list era.