-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up E0310 explanation #69233
Merged
Merged
Clean up E0310 explanation #69233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 17, 2020
Dylan-DPC-zz
suggested changes
Feb 17, 2020
must be as long as the data needs to be alive, and missing the constraint that | ||
denotes this will cause this error. | ||
A parameter type is missing a lifetime constraint or has a lifetime that | ||
doesn't live long enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
doesn't live long enough. | |
does not live long enough. |
@@ -11,6 +11,11 @@ struct Foo<T> { | |||
} | |||
``` | |||
|
|||
Type parameters in type definitions have lifetimes associated with them that | |||
represent how long the data stored within them is guaranteed to be live. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
represent how long the data stored within them is guaranteed to be live. This | |
represent how long the data stored within them is guaranteed to live. This |
GuillaumeGomez
force-pushed
the
cleanup-e0310
branch
from
February 18, 2020 12:08
654165a
to
73283f1
Compare
Updated! |
@bors r+ rollup |
📌 Commit 73283f1 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 18, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 18, 2020
…an-DPC Clean up E0310 explanation r? @Dylan-DPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC