Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regression test for issue #68794 #69168

Merged
merged 1 commit into from
Feb 15, 2020
Merged

add regression test for issue #68794 #69168

merged 1 commit into from
Feb 15, 2020

Conversation

brainlock
Copy link
Contributor

This is a minimal regression test for the issue #68794: "TEXTREL in
i686", which was fixed with e86019c.

The test links a minimal rust static library into a shared library, and
checks that the linker didn't have to add the TEXTREL flag.

@brainlock
add regression test for issue rust-lang#68794
ea2ffda 
This is a minimal regression test for the issue rust-lang#68794: "TEXTREL in
i686", which was fixed with e86019c.

The test links a minimal rust static library into a shared library, and
checks that the linker didn't have to add the TEXTREL flag.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2020
@Centril
Copy link
Contributor

Centril commented Feb 14, 2020

@bors rollup=never

tmandry
tmandry approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@tmandry tmandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this :)

Looks good to me, but I'd like a quick double check from either @alexcrichton or @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r=Mark-Simulacrum,tmandry

Thanks @Centril for marking as rollup=never; make tests are prone to ... subtle bugs.

@bors
Copy link
Contributor

bors commented Feb 15, 2020

📌 Commit ea2ffda has been approved by Mark-Simulacrum,tmandry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2020
@bors
Copy link
Contributor

bors commented Feb 15, 2020

⌛ Testing commit ea2ffda with merge 61d9231...

bors added a commit that referenced this pull request Feb 15, 2020
@bors
Auto merge of #69168 - brainlock:test-textrel-regression, r=Mark-Simu…
61d9231 
…lacrum,tmandry

add regression test for issue #68794

This is a minimal regression test for the issue #68794: "TEXTREL in
i686", which was fixed with e86019c.

The test links a minimal rust static library into a shared library, and
checks that the linker didn't have to add the TEXTREL flag.
@bors
Copy link
Contributor

bors commented Feb 15, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum,tmandry
Pushing 61d9231 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2020
@bors bors merged commit ea2ffda into rust-lang:master Feb 15, 2020
@brainlock brainlock mentioned this pull request Mar 2, 2020
Closed
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 3, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 3, 2020
Merged
@pnkfelix
Copy link
Member

pnkfelix commented Mar 5, 2020

discussed in T-compiler meeting. beta-accepted

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 5, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 5, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 5, 2020
Merged
bors added a commit that referenced this pull request Mar 6, 2020
@bors
Auto merge of #69748 - Mark-Simulacrum:beta-next, r=Mark-Simulacrum
b08d071 
[beta] another round of backports for 1.42

This backports the following pull requests:

* Fix a leak in `DiagnosticBuilder::into_diagnostic`. #69628
* stash API: remove panic to fix ICE. #69623
* Do not ICE on invalid type node after parse recovery #69583
* Backport only: avoid ICE on bad placeholder type #69324
* add regression test for issue #68794 #69168
* Update compiler-builtins to 0.1.25 #69086
* Update RELEASES.md for 1.42.0 #68989
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmandry tmandry tmandry approved these changes

Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@brainlock @rust-highfive @Centril @Mark-Simulacrum @bors @pnkfelix @tmandry @alexcrichton