Suggest borrowing Vec<NonCopy> in for loop
#68424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially address rust-lang#64167.
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jan 21, 2020
Centril
reviewed
Jan 21, 2020
|
@bors r=davidtwco |
|
📌 Commit 6eaf59d has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Jan 24, 2020
…y-vec, r=davidtwco Suggest borrowing `Vec<NonCopy>` in for loop Partially address rust-lang#64167.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Jan 24, 2020
…y-vec, r=davidtwco Suggest borrowing `Vec<NonCopy>` in for loop Partially address rust-lang#64167.
bors
added a commit
that referenced
this pull request
Jan 24, 2020
Rollup of 7 pull requests Successful merges: - #68424 (Suggest borrowing `Vec<NonCopy>` in for loop) - #68438 (Account for non-types in substs for opaque type error messages) - #68469 (Avoid overflow in `std::iter::Skip::count`) - #68473 (Enable ASan on Fuchsia) - #68479 (Implement `unused_parens` for block return values) - #68483 (Add my (@flip1995) name to .mailmap) - #68500 (Clear out std, not std tools) Failed merges: r? @ghost
oli-obk
reviewed
Jan 24, 2020
| let is_option = move_ty.starts_with("std::option::Option"); | ||
| let is_result = move_ty.starts_with("std::result::Result"); | ||
| let def_id = match move_place.ty(*self.body, self.infcx.tcx).ty.kind { | ||
| ty::Adt(self_def, _) => self_def.did, |
There was a problem hiding this comment.
Result, Vec and Option can't be anything but ty::Adt, so you can use ty_adt_def instead of manually matching on the TyKind variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #64167.