Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling tcx.hir().get() on CRATE_HIR_ID #68226

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

Aaron1011
Copy link
Member

This was causing an ICE when enabling trace logging for an unrelated
module, since the arguments to trace! ended up getting evaluated

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2020
@Aaron1011
Copy link
Member Author

@matthewjasper: Fixed

@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-14T21:29:58.7735884Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-14T21:29:58.7821073Z ##[command]git config gc.auto 0
2020-01-14T21:29:58.7902516Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-14T21:29:58.7959300Z ##[command]git config --get-all http.proxy
2020-01-14T21:29:58.8143184Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68226/merge:refs/remotes/pull/68226/merge
---
2020-01-14T21:36:13.8068025Z     Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-01-14T21:36:16.2020110Z     Checking rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
2020-01-14T21:36:16.8883933Z     Checking rustc_expand v0.0.0 (/checkout/src/librustc_expand)
2020-01-14T21:36:18.4108973Z     Checking rustc_builtin_macros v0.0.0 (/checkout/src/librustc_builtin_macros)
2020-01-14T21:36:18.7799356Z error: expected one of `,`, `.`, `?`, or an operator, found `tcx`
2020-01-14T21:36:18.7802908Z     --> src/librustc/infer/opaque_types/mod.rs:1223:9
2020-01-14T21:36:18.7803479Z 1222 |         tcx.hir().find(hir_id)
2020-01-14T21:36:18.7803479Z 1222 |         tcx.hir().find(hir_id)
2020-01-14T21:36:18.7803883Z      |                               - expected one of `,`, `.`, `?`, or an operator
2020-01-14T21:36:18.7804243Z 1223 |         tcx.hir().get(opaque_hir_id),
2020-01-14T21:36:18.7804664Z 
2020-01-14T21:36:40.1433952Z error: aborting due to previous error
2020-01-14T21:36:40.1434283Z 
2020-01-14T21:36:40.1435374Z error: could not compile `rustc`.
2020-01-14T21:36:40.1435374Z error: could not compile `rustc`.
2020-01-14T21:36:40.1435600Z 
2020-01-14T21:36:40.1435813Z To learn more, run the command again with --verbose.
2020-01-14T21:36:40.1437116Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--color" "always" "--features" " llvm" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
2020-01-14T21:36:40.1437271Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap check
2020-01-14T21:36:40.1437449Z Build completed unsuccessfully in 0:04:21
2020-01-14T21:36:40.1437494Z == clock drift check ==
2020-01-14T21:36:40.1437537Z   local time: Tue Jan 14 21:36:38 UTC 2020
2020-01-14T21:36:40.1437537Z   local time: Tue Jan 14 21:36:38 UTC 2020
2020-01-14T21:36:40.1437599Z   network time: Tue, 14 Jan 2020 21:36:39 GMT
2020-01-14T21:36:40.1437641Z == end clock drift check ==
2020-01-14T21:36:40.1437671Z 
2020-01-14T21:36:40.1502187Z ##[error]Bash exited with code '1'.
2020-01-14T21:36:40.1530112Z ##[section]Starting: Checkout
2020-01-14T21:36:40.1532619Z ==============================================================================
2020-01-14T21:36:40.1532678Z Task         : Get sources
2020-01-14T21:36:40.1532746Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

This was causing an ICE when enabling trace logging for an unrelated
module, since the arguments to `trace!` ended up getting evaluated
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 15, 2020

📌 Commit 01dc44b has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 15, 2020
…ewjasper

Avoid calling tcx.hir().get() on CRATE_HIR_ID

This was causing an ICE when enabling trace logging for an unrelated
module, since the arguments to `trace!` ended up getting evaluated
bors added a commit that referenced this pull request Jan 15, 2020
Rollup of 12 pull requests

Successful merges:

 - #67784 (Reset Formatter flags on exit from pad_integral)
 - #67914 (Don't run const propagation on items with inconsistent bounds)
 - #68141 (use winapi for non-stdlib Windows bindings)
 - #68211 (Add failing example for E0170 explanation)
 - #68219 (Untangle ZST validation from integer validation and generalize it to all zsts)
 - #68222 (Update the wasi-libc bundled with libstd)
 - #68226 (Avoid calling tcx.hir().get() on CRATE_HIR_ID)
 - #68227 (Update to a version of cmake with windows arm64 support)
 - #68229 (Update iovec to a version with no winapi dependency)
 - #68230 (Update libssh2-sys to a version that can build for aarch64-pc-windows…)
 - #68231 (Better support for cross compilation on Windows.)
 - #68233 (Update compiler_builtins with changes to fix 128 bit integer remainder for aarch64 windows.)

Failed merges:

r? @ghost
@bors bors merged commit 01dc44b into rust-lang:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants