-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expect fn
after const unsafe
/ const extern
#68073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 9, 2020
Centril
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
stable-nominated
Nominated for backporting to the compiler in the stable channel.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jan 9, 2020
@bors r+ rollup |
📌 Commit 915db7a has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 9, 2020
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 10, 2020
expect `fn` after `const unsafe` / `const extern` Fixes rust-lang#68062 r? @estebank @petrochenkov cc @Aaron1011
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 10, 2020
expect `fn` after `const unsafe` / `const extern` Fixes rust-lang#68062 r? @estebank @petrochenkov cc @Aaron1011
bors
added a commit
that referenced
this pull request
Jan 10, 2020
Rollup of 6 pull requests Successful merges: - #66463 (Point at opaque and closure type definitions in type errors) - #67501 (Reduce special treatment for zsts) - #67820 (Parse the syntax described in RFC 2632) - #67922 (rustc_ast_lowering: misc cleanup & rustc dep reductions) - #68071 (Extend support of `_` in type parameters) - #68073 (expect `fn` after `const unsafe` / `const extern`) Failed merges: r? @ghost
discussed at T-compiler meeting. beta-accepted. |
Centril
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Jan 16, 2020
discussed at T-compiler meeting. stable-accepted. |
pnkfelix
added
the
stable-accepted
Accepted for backporting to the compiler in the stable channel.
label
Jan 16, 2020
Merged
bors
added a commit
that referenced
this pull request
Jan 19, 2020
Beta backports - expect `fn` after `const unsafe` / `const extern` #68073 - Do not ICE on unicode next point #68084 - rustdoc: Don't allow `#![feature(...)]` on stable or beta #67989 r? @Mark-Simulacrum
Mark-Simulacrum
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Jan 23, 2020
Mark-Simulacrum
removed
stable-accepted
Accepted for backporting to the compiler in the stable channel.
stable-nominated
Nominated for backporting to the compiler in the stable channel.
labels
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68062
r? @estebank @petrochenkov
cc @Aaron1011