Extract rustc_hir out of rustc
#67803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Centril
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Zoxc
reviewed
Jan 4, 2020
Zoxc
reviewed
Jan 4, 2020
| impl<'a> HashStable<StableHashingContext<'a>> for ast::Attribute { | ||
| fn hash_stable(&self, hcx: &mut StableHashingContext<'a>, hasher: &mut StableHasher) { | ||
| impl<'ctx> syntax::HashStableContext for StableHashingContext<'ctx> { | ||
| fn hash_attr(&mut self, attr: &ast::Attribute, hasher: &mut StableHasher) { |
There was a problem hiding this comment.
I think it would be better to have a is_ignored_attr method on syntax::HashStableContext and move the impl to syntax.
There was a problem hiding this comment.
This doesn't work out well unfortunately. I'm only able to move one of the impls, but not the impl<AstCtx: crate::HashStableContext> HashStable<AstCtx> for [ast::Attribute] { one because it becomes orphaned (including with specialization). So I would prefer to have those impls in one place and this file is the only way to do that I think.
Zoxc
reviewed
Jan 4, 2020
| sugar.hash_stable(hcx, hasher); | ||
| } | ||
| hir::VisibilityKind::Restricted { ref path, hir_id } => { | ||
| hcx.with_node_id_hashing_mode(NodeIdHashingMode::HashDefPath, |hcx| { |
There was a problem hiding this comment.
You could add with_node_id_hashing_mode and while_hashing_hir_bodies to rustc_hir::HashStableContext then you wouldn't need to keep all the impls here.
Also fix fallout wrt. HashStable.
|
@bors r+ p=5 rollup=never |
|
📌 Commit cdf32e1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 4, 2020
Extract `rustc_hir` out of `rustc` The new crate contains: ```rust pub mod def; pub mod def_id; mod hir; pub mod hir_id; pub mod itemlikevisit; pub mod pat_util; pub mod print; mod stable_hash_impls; pub use hir::*; pub use hir_id::*; pub use stable_hash_impls::HashStableContext; ``` Remains to be done in follow-up PRs: - Move `rustc::hir::map` into `rustc_hir_map` -- this has to be a separate crate due to the `dep_graph` (blocked on #67761). - Move references to `rustc::hir` to `rustc_hir` where possible. cc #65031 r? @Zoxc
|
☀️ Test successful - checks-azure |
This was referenced Jan 5, 2020
Closed
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Jan 5, 2020
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Jan 5, 2020
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Jan 5, 2020
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jan 5, 2020
Rustup to rust-lang/rust#67803 and rust-lang/rust#67137 changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jan 5, 2020
Rustup to rust-lang/rust#67803 and rust-lang/rust#67137 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new crate contains:
Remains to be done in follow-up PRs:
Move
rustc::hir::mapintorustc_hir_map-- this has to be a separate crate due to thedep_graph(blocked on Move the dep_graph construction to a dedicated crate. #67761).Move references to
rustc::hirtorustc_hirwhere possible.cc #65031
r? @Zoxc