Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak impl signature mismatch errors involving RegionKind::ReVar lifetimes #67460

Merged
merged 12 commits into from
May 30, 2020
Merged

Tweak impl signature mismatch errors involving RegionKind::ReVar lifetimes #67460

merged 12 commits into from
May 30, 2020

Commits on May 27, 2020

  1. Fix spacing of expected/found notes without a label

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    3fea832 View commit details
    Browse the repository at this point in the history

  2. Name RegionKind::ReVar lifetimes in diagnostics

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    5ba2220 View commit details
    Browse the repository at this point in the history

  3. Tweak output for mismatched impl item 

    Detect type parameter that might require lifetime constraint.
Do not name `ReVar`s in expected/found output.
Reword text suggesting to check the lifetimes.
    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    eb0f4d5 View commit details
    Browse the repository at this point in the history

  4. review comments

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    3811232 View commit details
    Browse the repository at this point in the history

  5. review comment: use FxIndexSet

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    2e2f820 View commit details
    Browse the repository at this point in the history

  6. fix rebase

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    d0d30b0 View commit details
    Browse the repository at this point in the history

  7. Modify wording

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    2b35247 View commit details
    Browse the repository at this point in the history

  8. fix rebase

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    500504c View commit details
    Browse the repository at this point in the history

  9. fix rebase

    @estebank
    estebank committed May 27, 2020
    Configuration menu
    Copy the full SHA
    c52dbbc View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Fix rebase

    @estebank
    estebank committed May 28, 2020
    Configuration menu
    Copy the full SHA
    cb6408a View commit details
    Browse the repository at this point in the history

  2. review comments: change wording and visual output

    @estebank
    estebank committed May 28, 2020
    Configuration menu
    Copy the full SHA
    f213acf View commit details
    Browse the repository at this point in the history

  3. Account for Self as a type param

    @estebank
    estebank committed May 28, 2020
    Configuration menu
    Copy the full SHA
    1bd6970 View commit details
    Browse the repository at this point in the history