Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #67310

Merged
merged 12 commits into from
Dec 15, 2019
Merged

Rollup of 6 pull requests #67310

merged 12 commits into from
Dec 15, 2019

Commits on Dec 12, 2019

  1. Configuration menu
    Copy the full SHA
    0f47327 View commit details
    Browse the repository at this point in the history
  2. Fix signature of __wasilibc_find_relpath

    Looks like this function changed upstream, so it needs to be adjusted
    for when used by libstd.
    alexcrichton committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    641ccd5 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Configuration menu
    Copy the full SHA
    b65c6ec View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Restore original implementation of Vec::retain

    This PR reverts rust-lang#48065, which aimed to optimize `Vec::retain` by
    making use of `Vec::drain_filter`. Unfortunately at that time,
    `drain_filter` was unsound.
    
    The soundness hole in `Vec::drain_filter` was fixed in rust-lang#61224 by
    guaranteeing that cleanup logic runs via a nested `Drop`, even in
    the event of a panic. Implementing this nested drop affects codegen
    (apparently?) and results in slower code.
    
    Fixes rust-lang#65970
    aloucks committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    7ea6c46 View commit details
    Browse the repository at this point in the history
  2. Do not ICE on unnamed future

    estebank committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    e08944f View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2019

  1. Doc typo

    kappa authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    d0008ba View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#67255 - tuxillo:remove-i686-unknown-dragonf…

    …ly, r=alexcrichton
    
    Remove i686-unknown-dragonfly target
    
    DragonFly BSD removed support for i386 a while ago. It only supports x86_64 right now.
    Centril authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    009585a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#67267 - alexcrichton:update-wasi-libc, r=Dy…

    …lan-DPC
    
    Fix signature of `__wasilibc_find_relpath`
    
    Looks like this function changed upstream, so it needs to be adjusted
    for when used by libstd.
    Centril authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    39c5d81 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#67282 - pjw91:patch-1, r=Dylan-DPC

    Fix example code of OpenOptions::open
    
    The example didn't set the access mode flag, which resulted in an `Err(InvalidInput)`.
    
    r? @steveklabnik
    Centril authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    541dc62 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#67289 - estebank:unnamed-closure, r=Centril

    Do not ICE on unnamed future
    
    Fix rust-lang#67252.
    Centril authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    8e2689c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#67300 - aloucks:issue-65970, r=rkruppe

    Restore original implementation of Vec::retain
    
    This PR reverts rust-lang#48065, which aimed to optimize `Vec::retain` by making use of `Vec::drain_filter`. Unfortunately at that time, `drain_filter` was unsound.
    
    The soundness hole in `Vec::drain_filter` was fixed in rust-lang#61224 by guaranteeing that cleanup logic runs via a nested `Drop`, even in the event of a panic. Implementing this nested drop affects codegen (apparently?) and results in slower code.
    
    Fixes rust-lang#65970
    Centril authored Dec 15, 2019
    Configuration menu
    Copy the full SHA
    64f8391 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e5c3441 View commit details
    Browse the repository at this point in the history