Refactor expression parsing thoroughly #67112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Rebased (executed |
|
#66994 has landed so this is ready to go. :) |
This comment has been minimized.
This comment has been minimized.
|
Rebased. :) |
This comment has been minimized.
This comment has been minimized.
estebank
approved these changes
Dec 26, 2019
| | _______________^ | ||
| LL | | | ||
| LL | | } | ||
| | |_____^ expected `bool`, found `()` |
| // Has been misleading, at least in the past (closed Issue #48492). | ||
| Applicability::MaybeIncorrect, | ||
| ) | ||
| .emit(); |
There was a problem hiding this comment.
We could add extra checks here to not suggest in when it wouldn't be appropriate and bubble the error up in those cases.
There was a problem hiding this comment.
What situations do you have in mind for "inappropriate" ?
|
@bors r+ |
|
📌 Commit 7a246ac has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7a246ac with merge 98b05b6811d198d2601444d635c96d0309ce2edc... |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 26, 2019
Refactor expression parsing thoroughly Based on rust-lang#66994 together with which this has refactored basically the entirety of `expr.rs`. r? @estebank
|
@bors retry yield to rollup |
bors
added a commit
that referenced
this pull request
Dec 26, 2019
Rollup of 12 pull requests Successful merges: - #67112 (Refactor expression parsing thoroughly) - #67192 (Various const eval and pattern matching ICE fixes) - #67287 (typeck: note other end-point when checking range pats) - #67459 (prune ill-conceived BTreeMap iter_mut assertion and test its mutability) - #67576 (reuse `capacity` variable in slice::repeat) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67614 (Set callbacks globally) - #67617 (Remove `compiler_builtins_lib` documentation) - #67629 (Remove redundant link texts) - #67632 (Convert collapsed to shortcut reference links) - #67633 (Update .mailmap) - #67635 (Document safety of Path casting) Failed merges: r? @ghost
|
💔 Test failed - checks-azure |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
Is the |
|
☀️ Test successful - checks-azure |
@Zoxc Seems like it, cc @michaelwoerister. |
|
I've seen that test fail too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #66994 together with which this has refactored basically the entirety of
expr.rs.r? @estebank