Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle const-checks for &mut outside of HasMutInterior #66654

Merged
merged 12 commits into from
Dec 2, 2019
Merged

Handle const-checks for &mut outside of HasMutInterior #66654

merged 12 commits into from
Dec 2, 2019

Commits on Nov 27, 2019

  1. Add #![feature(matches_macro)]

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    b0b7dc3 View commit details
    Browse the repository at this point in the history

  2. Use type-based qualification for statics

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    6596165 View commit details
    Browse the repository at this point in the history

  3. Handle Rvalue::Ref in one place

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    66e9f88 View commit details
    Browse the repository at this point in the history

  4. Update test with improved diagnostics 

    Now, `derived_from_illegal_borrow` is also applied to reborrows, so we
don't show the user a useless error message.
    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    5a3ddcd View commit details
    Browse the repository at this point in the history

  5. Remove Rvalue::Ref handling from HasMutInterior

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    5a10430 View commit details
    Browse the repository at this point in the history

  6. Remove derived_from_illegal_borrow

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    5117407 View commit details
    Browse the repository at this point in the history

  7. Remove CheckOpResult

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    dd32d91 View commit details
    Browse the repository at this point in the history

  8. Also test shared borrows of Cell for good errors

    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    d2bdaa8 View commit details
    Browse the repository at this point in the history

  9. Remove test for unused error code 

    This error code is never emitted, and the contents of this test are
identical to that of `E0017.rs`.
    @ecstatic-morse
    ecstatic-morse committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    5b1e10b View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Don't treat a reference to a static as a reborrow 

    They now look the same in the MIR after rust-lang#66587.
    @ecstatic-morse
    ecstatic-morse committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    a70ac50 View commit details
    Browse the repository at this point in the history

  2. Update test for mutably borrowed statics in a const 

    This checks `static mut` as well for E0017, and blesses tests now that
we emit an error for a mut deref.
    @ecstatic-morse
    ecstatic-morse committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    846be82 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2019

  1. Incorporate fixes from review

    @ecstatic-morse
    ecstatic-morse committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    ccb4eed View commit details
    Browse the repository at this point in the history