-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #66640
Rollup of 8 pull requests #66640
Commits on Nov 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9a88364 - Browse repository at this point
Copy the full SHA 9a88364View commit details
Commits on Nov 20, 2019
-
Remove pretty printing of specific nodes in AST
The ability to print a specific item as identified by NodeId or path seems not particularly useful, and certainly carries quite a bit of complexity with it.
Configuration menu - View commit details
-
Copy full SHA for 7ec20dd - Browse repository at this point
Copy the full SHA 7ec20ddView commit details
Commits on Nov 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a1d04cc - Browse repository at this point
Copy the full SHA a1d04ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae9677c - Browse repository at this point
Copy the full SHA ae9677cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3600695 - Browse repository at this point
Copy the full SHA 3600695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47a3294 - Browse repository at this point
Copy the full SHA 47a3294View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6d97df - Browse repository at this point
Copy the full SHA c6d97dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9abc34e - Browse repository at this point
Copy the full SHA 9abc34eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 025630d - Browse repository at this point
Copy the full SHA 025630dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bccc59a - Browse repository at this point
Copy the full SHA bccc59aView commit details
Commits on Nov 22, 2019
-
Document pitfall with
impl PartialEq<B> for A
Fixes rust-lang#66476 by turning the violating example into an explicit counterexample.
Configuration menu - View commit details
-
Copy full SHA for 5028fd8 - Browse repository at this point
Copy the full SHA 5028fd8View commit details -
follow the convention in this file to use third-person singular verbs
Guanqun Lu committedNov 22, 2019 Configuration menu - View commit details
-
Copy full SHA for da5539c - Browse repository at this point
Copy the full SHA da5539cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff91ab - Browse repository at this point
Copy the full SHA 9ff91abView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea62c2e - Browse repository at this point
Copy the full SHA ea62c2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60d9c2c - Browse repository at this point
Copy the full SHA 60d9c2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f798804 - Browse repository at this point
Copy the full SHA f798804View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bb2e3c - Browse repository at this point
Copy the full SHA 9bb2e3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8de11c - Browse repository at this point
Copy the full SHA a8de11cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94b7ea9 - Browse repository at this point
Copy the full SHA 94b7ea9View commit details -
Rollup merge of rust-lang#66183 - Centril:empty-vis-trait-decl, r=pet…
…rochenkov *Syntactically* permit visibilities on trait items & enum variants Fixes rust-lang#65041 Suppose we have `$vis trait_item` or `$vis enum_variant` and `$vis` is a `:vis` macro fragment. Before this PR, this would fail to parse. This is now instead allowed as per language team consensus in rust-lang#65041 (comment). (See added tests for elaboration.) Moreover, we now also permit visibility modifiers on trait items & enum variants *syntactically* but reject them with semantic checks (in `ast_validation`): ```rust #[cfg(FALSE)] trait Foo { pub fn bar(); } // OK #[cfg(FALSE)] enum E { pub U } // OK ```
Configuration menu - View commit details
-
Copy full SHA for 8cba0a9 - Browse repository at this point
Copy the full SHA 8cba0a9View commit details -
Rollup merge of rust-lang#66566 - robamler:issue-66476, r=rkruppe
Document pitfall with `impl PartialEq<B> for A` Fixes rust-lang#66476 by turning the violating example into an explicit counterexample.
Configuration menu - View commit details
-
Copy full SHA for afc78e1 - Browse repository at this point
Copy the full SHA afc78e1View commit details -
Rollup merge of rust-lang#66575 - Mark-Simulacrum:no-uii, r=petrochenkov
Remove pretty printing of specific nodes in AST The ability to print a specific item as identified by NodeId or path seems not particularly useful, and certainly carries quite a bit of complexity with it. This is intended to simplify our CLI parsing a bit and remove a non-uncomplicated piece of it; I largely did this to remove the dependency on NodeId from librustc/session but it's not really necessary to do so in this invasive a way. The alternative is moving it to librustc_interface or driver, probably.
Configuration menu - View commit details
-
Copy full SHA for c66b508 - Browse repository at this point
Copy the full SHA c66b508View commit details -
Rollup merge of rust-lang#66587 - matthewjasper:handle-static-as-cons…
…t, r=oli-obk Handle statics in MIR as const pointers This is the first PR towards the goal of removing `PlaceBase::Static`. In this PR: * Statics are lowered to dereferencing a const pointer. * The temporaries holding such pointers are tracked in MIR, for the most part this is only used for diagnostics. There are two exceptions: * The borrow checker has some checks for thread-locals that directly use this data. * Const checking will suppress "cannot dereference raw pointer" diagnostics for pointers to `static mut`/`extern static`. This is to maintain the current behaviour (12 tests fail otherwise). The following are left to future PRs (I think that @spastorino will be working on the first 3): * Applying the same treatments to promoted statics. * Removing `PlaceBase::Static`. * Replacing `PlaceBase` with `Local`. * Moving the ever growing collection of metadata that we have for diagnostics in MIR passes somewhere more appropriate. r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 3031720 - Browse repository at this point
Copy the full SHA 3031720View commit details -
Rollup merge of rust-lang#66619 - guanqun:use-third-person-singular-v…
…erb, r=Centril follow the convention in this file to use third-person singular verbs
Configuration menu - View commit details
-
Copy full SHA for a699945 - Browse repository at this point
Copy the full SHA a699945View commit details -
Rollup merge of rust-lang#66633 - GuillaumeGomez:err-codes-cleanup, r…
…=Dylan-DPC Error code's long explanation cleanup Continuing to clean up the error code's long explanation. r? @Dylan-DPC
Configuration menu - View commit details
-
Copy full SHA for 8be9e90 - Browse repository at this point
Copy the full SHA 8be9e90View commit details -
Rollup merge of rust-lang#66637 - RalfJung:typo, r=Centril
fix reoccuring typo: dereferencable -> dereferenceable
Configuration menu - View commit details
-
Copy full SHA for fd3bd29 - Browse repository at this point
Copy the full SHA fd3bd29View commit details -
Rollup merge of rust-lang#66639 - Centril:simplify-fresh-binding, r=p…
…etrochenkov resolve: more declarative `fresh_binding` Following up on rust-lang#64111, this PR redefines `fresh_binding` wrt. `already_bound_and` and `already_bound_or` in a more declarative and simplified fashion. cc rust-lang#54883 r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for 56512b9 - Browse repository at this point
Copy the full SHA 56512b9View commit details