Fix selected crate search filter #66514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
|
r? @Dylan-DPC |
kinnison
reviewed
Nov 19, 2019
|
Sure, here you go: |
|
So in local testing it doesn't seem to remember the crate selection for the search field when I build from your branch. Am I meant to run up a local webserver for it to work? |
kinnison
approved these changes
Nov 19, 2019
|
@bors r+ |
|
📌 Commit 00ef5c1 has been approved by |
bors
added
S-waiting-on-bors
|
Neat! 🎉 |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 20, 2019
…ve, r=kinnison Fix selected crate search filter Fixes rust-lang#62929. r? @kinnison
bors
added a commit
that referenced
this pull request
Nov 20, 2019
Rollup of 7 pull requests Successful merges: - #66060 (Making ICEs and test them in incremental) - #66298 (rustdoc: fixes #64305: disable search field instead of hidding it) - #66457 (Just derive Hashstable in librustc) - #66496 (rustc_metadata: Privatize more things) - #66514 (Fix selected crate search filter) - #66535 (Avoid ICE when `break`ing to an unreachable label) - #66573 (Ignore run-make reproducible-build-2 on Mac) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62929.
r? @kinnison