-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify pattern-matching usefulness algorithm #65874
Merged
Merged
Commits on Oct 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a5de5a6 - Browse repository at this point
Copy the full SHA a5de5a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for af35934 - Browse repository at this point
Copy the full SHA af35934View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7986599 - Browse repository at this point
Copy the full SHA 7986599View commit details -
Clarify and fix the explanation of the algorithm
There was a bit of confusion between individual patterns and lists of patterns, and index mismatches linked to that. This introduces a vocabulary of "pattern-stacks" to provide a clearer mental model of what is happening. This also adds examples.
Configuration menu - View commit details
-
Copy full SHA for 2665b64 - Browse repository at this point
Copy the full SHA 2665b64View commit details
Commits on Nov 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 403d6bd - Browse repository at this point
Copy the full SHA 403d6bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23ca38e - Browse repository at this point
Copy the full SHA 23ca38eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e734be - Browse repository at this point
Copy the full SHA 5e734beView commit details -
Remove duplicate logic in compute_missing_constructors
This is equivalent to the previous code in terms of performance. The expensive path is clearly identical. The fast path is also the same, because in both cases we loop until we get a non-empty `refined_ctors`, and then stop there. So the new code doesn't compute anything more than the previous did.
Configuration menu - View commit details
-
Copy full SHA for 0c02c19 - Browse repository at this point
Copy the full SHA 0c02c19View commit details -
Configuration menu - View commit details
-
Copy full SHA for b454581 - Browse repository at this point
Copy the full SHA b454581View commit details -
Configuration menu - View commit details
-
Copy full SHA for 175976e - Browse repository at this point
Copy the full SHA 175976eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a656a - Browse repository at this point
Copy the full SHA 57a656aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d663c27 - Browse repository at this point
Copy the full SHA d663c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc4583d - Browse repository at this point
Copy the full SHA cc4583dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92101b7 - Browse repository at this point
Copy the full SHA 92101b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7fa9f1 - Browse repository at this point
Copy the full SHA b7fa9f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8956c1e - Browse repository at this point
Copy the full SHA 8956c1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a96d700 - Browse repository at this point
Copy the full SHA a96d700View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.