-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #65548
Rollup of 13 pull requests #65548
Commits on Sep 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f04ea6c - Browse repository at this point
Copy the full SHA f04ea6cView commit details
Commits on Oct 8, 2019
-
Disable Go and OCaml bindings when building LLVM
Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.
Configuration menu - View commit details
-
Copy full SHA for 3b0fd82 - Browse repository at this point
Copy the full SHA 3b0fd82View commit details
Commits on Oct 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 77f0aaf - Browse repository at this point
Copy the full SHA 77f0aafView commit details
Commits on Oct 16, 2019
-
Use a
BitSet
inLexicalResolver::iterate_until_fixed_point()
.This wins 3% on `unicode_normalization`.
Configuration menu - View commit details
-
Copy full SHA for 70b136d - Browse repository at this point
Copy the full SHA 70b136dView commit details -
Inline and remove
iterate_until_fixed_point()
.The commit also removes the debug statement, because they annoyed me. This change wins another 1% on `unicode_normalization`, at least partly because it no longer needs to increment `iteration`.
Configuration menu - View commit details
-
Copy full SHA for d51fee0 - Browse repository at this point
Copy the full SHA d51fee0View commit details
Commits on Oct 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 42c0236 - Browse repository at this point
Copy the full SHA 42c0236View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1db077 - Browse repository at this point
Copy the full SHA d1db077View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21d9258 - Browse repository at this point
Copy the full SHA 21d9258View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83e97c6 - Browse repository at this point
Copy the full SHA 83e97c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cd9276 - Browse repository at this point
Copy the full SHA 4cd9276View commit details -
Configuration menu - View commit details
-
Copy full SHA for f647c06 - Browse repository at this point
Copy the full SHA f647c06View commit details -
Plugins deprecation: don’t suggest simply removing the attribute
Building Servo with a recent Nightly produces: ```rust warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See rust-lang#29597 --> components/script/lib.rs:14:1 | 14 | #![plugin(script_plugins)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(deprecated)]` on by default ``` First, linking to rust-lang#29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion. Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable. In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful. This PR also changes the message to be more factual.
Configuration menu - View commit details
-
Copy full SHA for 71b0049 - Browse repository at this point
Copy the full SHA 71b0049View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4d9492 - Browse repository at this point
Copy the full SHA a4d9492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e6efe4 - Browse repository at this point
Copy the full SHA 4e6efe4View commit details -
Co-Authored-By: Mark Rousskov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5487994 - Browse repository at this point
Copy the full SHA 5487994View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0b7e76 - Browse repository at this point
Copy the full SHA c0b7e76View commit details -
Configuration menu - View commit details
-
Copy full SHA for db94656 - Browse repository at this point
Copy the full SHA db94656View commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d0eaf60 - Browse repository at this point
Copy the full SHA d0eaf60View commit details -
Make
TokenStream::from_iter
less general and more efficient.The current code has this impl: ``` impl<T: Into<TokenStream>> iter::FromIterator<T> for TokenStream ``` If given an `IntoIterator<Item = TokenTree>`, it will convert each individual `TokenTree` to a `TokenStream` (at the cost of two allocations: a `Vec` and an `Lrc`). It will then merge those `TokenStream`s into a single `TokenStream`. This is inefficient. This commit changes the impl to this less general one: ``` impl iter::FromIterator<TokenTree> for TokenStream ``` It collects the `TokenTree`s into a single `Vec` first and then converts that to a `TokenStream` by wrapping it in a single `Lrc`. The previous generality was unnecessary; no other code needs changing. This change speeds up several benchmarks by up to 4%.
Configuration menu - View commit details
-
Copy full SHA for a6eef29 - Browse repository at this point
Copy the full SHA a6eef29View commit details -
Change
Lit::tokens()
toLit::token_tree()
.Because most of the call sites have an easier time working with a `TokenTree` instead of a `TokenStream`.
Configuration menu - View commit details
-
Copy full SHA for 212ae58 - Browse repository at this point
Copy the full SHA 212ae58View commit details -
Change
MetaItem::tokens()
toMetaItem::token_trees_and_joints()
.Likewise for `NestedMetaItem::tokens()`. Also, add `MetaItemKind::token_trees_and_joints()`, which `MetaItemKind::tokens()` now calls. This avoids some unnecessary `TokenTree` to `TokenStream` conversions, and removes the need for the clumsy `TokenStream::append_to_tree_and_joint_vec()`.
Configuration menu - View commit details
-
Copy full SHA for e4ec4a6 - Browse repository at this point
Copy the full SHA e4ec4a6View commit details -
Rollup merge of rust-lang#64925 - ehuss:document-json, r=Mark-Simulacrum
Document JSON message output. This documents the JSON messages in the rustc book.
Configuration menu - View commit details
-
Copy full SHA for cb41fb6 - Browse repository at this point
Copy the full SHA cb41fb6View commit details -
Rollup merge of rust-lang#65201 - tmiasko:no-bindings, r=rkruppe
Disable Go and OCaml bindings when building LLVM Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.
Configuration menu - View commit details
-
Copy full SHA for d913212 - Browse repository at this point
Copy the full SHA d913212View commit details -
Rollup merge of rust-lang#65334 - GuillaumeGomez:long-err-explanation…
…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.
Configuration menu - View commit details
-
Copy full SHA for a8ae1eb - Browse repository at this point
Copy the full SHA a8ae1ebView commit details -
Rollup merge of rust-lang#65417 - weiznich:more_coherence_tests, r=ni…
…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for ce4349e - Browse repository at this point
Copy the full SHA ce4349eView commit details -
Rollup merge of rust-lang#65455 - nnethercote:avoid-unnecessary-Token…
…Tree-to-TokenStream-conversions, r=petrochenkov Avoid unnecessary `TokenTree` to `TokenStream` conversions A `TokenStream` contains any number of `TokenTrees`. Therefore, a single `TokenTree` can be promoted to a `TokenStream`. But doing so costs two allocations: one for the single-element `Vec`, and one for the `Lrc`. (An `IsJoint` value also must be added; the default is `NonJoint`.) The current code converts `TokenTree`s to `TokenStream`s unnecessarily in a few places. This PR removes some of these unnecessary conversions, both simplifying the code and speeding it up. r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for 0a866a3 - Browse repository at this point
Copy the full SHA 0a866a3View commit details -
Rollup merge of rust-lang#65472 - Zoxc:sharded-dep-graph-2, r=nikomat…
…sakis Use a sharded dep node to dep node index map Split out from rust-lang#61845 and based on rust-lang#63756. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 7a49208 - Browse repository at this point
Copy the full SHA 7a49208View commit details -
Rollup merge of rust-lang#65480 - nnethercote:rm-iterate_until_fixed_…
…size, r=nikomatsakis Speed up `LexicalResolve::expansion()` A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 8cb6225 - Browse repository at this point
Copy the full SHA 8cb6225View commit details -
Rollup merge of rust-lang#65493 - GuillaumeGomez:long-err-explanation…
…-E0584, r=kinnison Add long error explanation for E0584 Part of rust-lang#61137. r? @kinnison
Configuration menu - View commit details
-
Copy full SHA for f1d4ce4 - Browse repository at this point
Copy the full SHA f1d4ce4View commit details -
Rollup merge of rust-lang#65496 - tspiteri:euc-div-panic, r=KodrAus
properly document panics in div_euclid and rem_euclid For signed numbers, document that `div_euclid` and `rem_euclid` panic not just when `rhs` is 0, but also when the division overflows. For unsigned numbers, document that `div_euclid` and `rem_euclid` panic when `rhs` is 0.
Configuration menu - View commit details
-
Copy full SHA for 0c6b6ad - Browse repository at this point
Copy the full SHA 0c6b6adView commit details -
Rollup merge of rust-lang#65498 - SimonSapin:plugin-help, r=Centril
Plugins deprecation: don’t suggest simply removing the attribute Building Servo with a recent Nightly produces: ```rust warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See rust-lang#29597 --> components/script/lib.rs:14:1 | 14 | #![plugin(script_plugins)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(deprecated)]` on by default ``` First, linking to rust-lang#29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion. Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable. In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful. This PR also changes the message to be more factual.
Configuration menu - View commit details
-
Copy full SHA for 570bc27 - Browse repository at this point
Copy the full SHA 570bc27View commit details -
Rollup merge of rust-lang#65508 - rust-lang:llvm-icebreakers-ping-1, …
…r=simulacrum add option to ping llvm ice-breakers to triagebot
Configuration menu - View commit details
-
Copy full SHA for 8ccea93 - Browse repository at this point
Copy the full SHA 8ccea93View commit details -
Rollup merge of rust-lang#65513 - RalfJung:fmt, r=Mark-Simulacrum
reorder fmt docs for more clarity I adjusted these docs in rust-lang#65332 but wasn't happy with the result when seeing it in rustdoc. So this reorders the subsections in the "Formatting Parameters" section to be more logical (subsections that reference `width` come after the `width` subsection) and they also all have examples now.
Configuration menu - View commit details
-
Copy full SHA for 0e49753 - Browse repository at this point
Copy the full SHA 0e49753View commit details -
Rollup merge of rust-lang#65531 - tmandry:bump-backtrace, r=cramertj
Update backtrace to 0.3.40 Diff: rust-lang/backtrace-rs@0.3.37...b5cc5b1 Pretty low risk, considering the only changes are in low-tier targets. r? @cramertj cc @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 772a8d2 - Browse repository at this point
Copy the full SHA 772a8d2View commit details