Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_codegen_ssa: remove some unnecessary Box special-casing. #65448

Merged
merged 1 commit into from
Oct 19, 2019
Merged

rustc_codegen_ssa: remove some unnecessary Box special-casing. #65448

merged 1 commit into from
Oct 19, 2019

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Oct 15, 2019

Could help simplify #60900.

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@eddyb
Copy link
Member Author

eddyb commented Oct 15, 2019

@bors try (for perf)

@bors
Copy link
Contributor

bors commented Oct 15, 2019

⌛ Trying commit c39af6e with merge fe00dd0ab564055bb73c11adb998cdabbd8ee569...

@bors
Copy link
Contributor

bors commented Oct 15, 2019

☀️ Try build successful - checks-azure
Build commit: fe00dd0ab564055bb73c11adb998cdabbd8ee569 (fe00dd0ab564055bb73c11adb998cdabbd8ee569)

@eddyb

This comment has been minimized.

Sign in to view
1 similar comment
@eddyb
Copy link
Member Author

eddyb commented Oct 16, 2019

@rust-timer build fe00dd0ab564055bb73c11adb998cdabbd8ee569

@rust-timer
Copy link
Collaborator

Queued fe00dd0ab564055bb73c11adb998cdabbd8ee569 with parent 237d54f, future comparison URL.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 18, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 18, 2019

📌 Commit c39af6e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 19, 2019
@Centril
Rollup merge of rust-lang#65448 - eddyb:codegen-box-less-special, r=o…
5532699 
…li-obk

rustc_codegen_ssa: remove some unnecessary Box special-casing.

Could help simplify rust-lang#60900.

r? @nikomatsakis
@Centril Centril mentioned this pull request Oct 19, 2019
Merged
bors added a commit that referenced this pull request Oct 19, 2019
@bors
Auto merge of #65598 - Centril:rollup-vc6ht2c, r=Centril
c491875 
Rollup of 5 pull requests

Successful merges:

 - #64007 (Add check for overlapping ranges to unreachable patterns lint)
 - #65192 (Use structured suggestion for restricting bounds)
 - #65226 (BTreeSet symmetric_difference & union optimized)
 - #65448 (rustc_codegen_ssa: remove some unnecessary Box special-casing.)
 - #65505 (Rc: value -> allocation)

Failed merges:

r? @ghost
@bors bors merged commit c39af6e into rust-lang:master Oct 19, 2019
@bors
Copy link
Contributor

bors commented Oct 19, 2019

☔ The latest upstream changes (presumably #65598) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2019
@eddyb eddyb deleted the codegen-box-less-special branch October 19, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eddyb @bors @rust-timer @oli-obk @nikomatsakis @rust-highfive