Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #65399

Merged
merged 23 commits into from
Oct 14, 2019
Merged

Rollup of 7 pull requests #65399

merged 23 commits into from
Oct 14, 2019

Commits on Oct 10, 2019

  1. Configuration menu
    Copy the full SHA
    e0ef776 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Configuration menu
    Copy the full SHA
    2ae5e34 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Apply suggestion

    JohnTitor committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    c6cc29d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d131abe View commit details
    Browse the repository at this point in the history
  3. ast: remove implicit pprust dependency via Display.

    Instead just use `pprust::path_to_string(..)` where needed.
    
    This has two benefits:
    
    a) The AST definition is now independent of printing it.
       (Therefore we get closer to extracting a data-crate.)
    
    b) Debugging should be easier as program flow is clearer.
    Centril committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    742ec4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab8105e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4a0c487 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9d766ed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    42f32f0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1899432 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    07e946c View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Add test for issue-44153

    JohnTitor committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    5c8fdc1 View commit details
    Browse the repository at this point in the history
  2. Add test for issue-47486

    JohnTitor committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    6323180 View commit details
    Browse the repository at this point in the history
  3. Add test for issue-48010

    JohnTitor committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    f653db9 View commit details
    Browse the repository at this point in the history
  4. Add test for issue-48027

    JohnTitor committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    88a495c View commit details
    Browse the repository at this point in the history
  5. Add test for issue-48638

    JohnTitor committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    f6e01e8 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#65215 - JohnTitor:long-explanation-e0697, r…

    …=GuillaumeGomez
    
    Add long error explanation for E0697
    
    Part of rust-lang#61137
    
    r? @GuillaumeGomez
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    1ac0028 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#65292 - JohnTitor:add-backticks, r=varkor,C…

    …entril
    
    Print lifetimes with backticks
    
    Fixes rust-lang#65287
    
    r? @varkor
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    c2ae4de View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#65362 - Centril:extract_fun, r=petrochenkov

    syntax: consolidate function parsing in item.rs
    
    Extracted from rust-lang#65324.
    
    r? @estebank
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    66e4288 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#65363 - Centril:less-pprust, r=Mark-Simulacrum

    Remove implicit dependencies on syntax::pprust
    
    Part of rust-lang#65324.
    
    The main goal here is to facilitate the eventual move of pprust out from libsyntax and because an AST definition typically should not depend on its pretty printer.
    
    r? @estebank
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    2800bc2 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#65379 - Centril:refactor-bso_and_cc, r=petr…

    …ochenkov
    
    refactor session::config::build_session_options_and_crate_config
    
    I'm not exactly sure what happened in rust-lang#65361 (comment) so in an effort to bisect the error I'm extracting out the first commit so it can hopefully land (I suspect the error is in the 2nd-3rd commits.)
    
    r? @petrochenkov
    
    (I'll r=you when the PR builder is happy)
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    e29a6fc View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#65392 - Centril:nt-to-tt, r=Mark-Simulacrum

    Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering
    
    Split out from rust-lang#65324.
    
    r? @petrochenkov
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    28d08f3 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#65395 - JohnTitor:add-tests, r=Centril

    Add some tests for fixed ICEs
    
    Fixes rust-lang#44153 (from 1.23.0)
    Fixes rust-lang#47486 (from 1.36.0)
    Fixes rust-lang#48010 (from 1.38.0)
    Fixes rust-lang#48027 (from nightly)
    Fixes rust-lang#48638 (from nightly)
    Centril authored Oct 14, 2019
    Configuration menu
    Copy the full SHA
    a73e073 View commit details
    Browse the repository at this point in the history