Rollup of 15 pull requests #65322
Merged
Rollup of 15 pull requests #65322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unclear what the implementation does when it encounters existing keys. This change makes it clear by documenting the trait impl.
This example failed to compile because of implicit `Sized` bound for `A` parameter that wasn't required by `Trait`.
function pointer const parameters.
const_compare_raw_pointers.
Co-Authored-By: varkor <[email protected]>
Updates LLVM to pick up the cherry-picked support for correctly handling exception handling with aggregates passed by value. This will be necessary to continue to support Emscripten's exception handling once we switch using Emscripten's LLVM backend. See rust-lang#63649.
I've accidentally did `mut_path_buf.jon(a_path);`, expecting this to be an in-place modification. Seems like we can easily warn in such cases?
…-E0568, r=estebank Add long error explanation for E0568 Part of rust-lang#61137.
…exceptions, r=nikic Update LLVM for Emscripten exception handling support Updates LLVM to pick up the cherry-picked support for correctly handling exception handling with aggregates passed by value. This will be necessary to continue to support Emscripten's exception handling once we switch using Emscripten's LLVM backend. See rust-lang#63649.
…tril
Deduplicate is_{freeze,copy,sized}_raw
Fixes rust-lang#65259
Deduplicates `is_{freeze,copy,sized}_raw` by delegating to a new method which takes in a `LangItem`.
Mark Path::join as must_use I've accidentally did `mut_path_buf.jon(a_path);`, expecting this to be an in-place modification. Seems like we can easily warn in such cases?
…mulacrum Don't cc rust-lang/compiler for toolstate changes Fixes rust-lang#65238.
Query generator kind for error reporting Fixes rust-lang#65166 (comment) r? @estebank cc @cramertj
stability: Do not use `buffer_lint` after lowering to HIR Fixes rust-lang#65253
Fix suggested bound addition diagnostic Fixes rust-lang#65284.
deriving: avoid dummy Span on an artificial `type_ident` path The dummy Span pointed to the beginning of the source file instead to where the `#[derive]` is located. Later, it tripped the `in_derive_expansion(span)` check at `src/librustc/middle/stability.rs`, causing a span-less deprecation warning to be emitted. Fixes rust-lang#56195, Fixes rust-lang#55417.
…f8-test, r=nikomatsakis Remove painful test that is not pulling its weight Research suggests that we are not properly testing this case anyway, and even if we were, it is unlikely that we will regress here -- or, perhaps more accurately, if we do, I am uncertain that we care too much. It definitely seems like an edge case, and one that is particularly unlikely to occur as time goes on. Fixes rust-lang#63520
|
@bors r+ p=15 rollup=never |
|
📌 Commit b93203f has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit b93203f with merge 632883eccb714e0ef4e913f905a30f8dd9e009cd... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 12, 2019
Rollup of 15 pull requests Successful merges: - #64337 (libstd: Fix typos in doc) - #64986 (Function pointers as const generic arguments) - #65048 (Added doc about behavior of extend on HashMap) - #65191 (Add some regression tests) - #65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - #65205 (Add long error explanation for E0568) - #65220 (Update LLVM for Emscripten exception handling support) - #65263 (Deduplicate is_{freeze,copy,sized}_raw) - #65266 (Mark Path::join as must_use) - #65276 (Don't cc rust-lang/compiler for toolstate changes) - #65277 (Query generator kind for error reporting) - #65283 (stability: Do not use `buffer_lint` after lowering to HIR) - #65289 (Fix suggested bound addition diagnostic) - #65310 (deriving: avoid dummy Span on an artificial `type_ident` path) - #65321 (Remove painful test that is not pulling its weight) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
This was referenced Oct 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
buffer_lintafter lowering to HIR #65283 (stability: Do not usebuffer_lintafter lowering to HIR)type_identpath #65310 (deriving: avoid dummy Span on an artificialtype_identpath)Failed merges:
r? @ghost