-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add const-eval support for SIMD types, insert, and extract #64738
Changes from all commits
03ac54a
75d8199
f0bbd2b
e6239bb
3a6e96e
97ce904
02b3234
5976674
e74a268
e1cf0a1
02bfbf9
5ecb7eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -335,6 +335,17 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> { | |
} | ||
} | ||
|
||
/// Read vector length and element type | ||
pub fn read_vector_ty( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't even look at the actual "operand", right? It is just a layout function? Then it (a) should be mixed up with all the other I am not sure what the best place is for such a method, but it is not |
||
&self, op: OpTy<'tcx, M::PointerTag> | ||
) -> (u64, &rustc::ty::TyS<'tcx>) { | ||
if let layout::Abi::Vector { .. } = op.layout.abi { | ||
(op.layout.ty.simd_size(*self.tcx) as _, op.layout.ty.simd_type(*self.tcx)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why this is not using the element count from |
||
} else { | ||
bug!("Type `{}` is not a SIMD vector type", op.layout.ty) | ||
} | ||
} | ||
|
||
/// Read a scalar from a place | ||
pub fn read_scalar( | ||
&self, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -249,9 +249,6 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> { | |
|
||
match instance.def { | ||
ty::InstanceDef::Intrinsic(..) => { | ||
if caller_abi != Abi::RustIntrinsic { | ||
throw_unsup!(FunctionAbiMismatch(caller_abi, Abi::RustIntrinsic)) | ||
} | ||
Comment on lines
-252
to
-254
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Uh, why this? Instead of throwing out this check entirely, you could have just added platform intrinsics to the whitelist. |
||
// The intrinsic itself cannot diverge, so if we got here without a return | ||
// place... (can happen e.g., for transmute returning `!`) | ||
let dest = match dest { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
// run-pass | ||
#![feature(const_fn)] | ||
#![feature(repr_simd)] | ||
#![feature(platform_intrinsics)] | ||
#![allow(non_camel_case_types)] | ||
|
||
#[repr(simd)] struct i8x1(i8); | ||
#[repr(simd)] struct u16x2(u16, u16); | ||
#[repr(simd)] struct f32x3(f32, f32, f32); | ||
|
||
extern "platform-intrinsic" { | ||
fn simd_insert<T, U>(x: T, idx: u32, val: U) -> T; | ||
fn simd_extract<T, U>(x: T, idx: u32) -> U; | ||
} | ||
|
||
fn main() { | ||
{ | ||
const U: i8x1 = i8x1(13); | ||
const V: i8x1 = unsafe { simd_insert(U, 0_u32, 42_i8) }; | ||
const X0: i8 = V.0; | ||
const Y0: i8 = unsafe { simd_extract(V, 0) }; | ||
assert_eq!(X0, 42); | ||
assert_eq!(Y0, 42); | ||
} | ||
{ | ||
const U: u16x2 = u16x2(13, 14); | ||
const V: u16x2 = unsafe { simd_insert(U, 1_u32, 42_u16) }; | ||
const X0: u16 = V.0; | ||
const X1: u16 = V.1; | ||
const Y0: u16 = unsafe { simd_extract(V, 0) }; | ||
const Y1: u16 = unsafe { simd_extract(V, 1) }; | ||
assert_eq!(X0, 13); | ||
assert_eq!(X1, 42); | ||
assert_eq!(Y0, 13); | ||
assert_eq!(Y1, 42); | ||
} | ||
{ | ||
const U: f32x3 = f32x3(13., 14., 15.); | ||
const V: f32x3 = unsafe { simd_insert(U, 1_u32, 42_f32) }; | ||
const X0: f32 = V.0; | ||
const X1: f32 = V.1; | ||
const X2: f32 = V.2; | ||
const Y0: f32 = unsafe { simd_extract(V, 0) }; | ||
const Y1: f32 = unsafe { simd_extract(V, 1) }; | ||
const Y2: f32 = unsafe { simd_extract(V, 2) }; | ||
assert_eq!(X0, 13.); | ||
assert_eq!(X1, 42.); | ||
assert_eq!(X2, 15.); | ||
assert_eq!(Y0, 13.); | ||
assert_eq!(Y1, 42.); | ||
assert_eq!(Y2, 15.); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite confusing to call something of type
OpTy
a "scalar". Those should have typeScalar
, or this should be called somewhere else, or there should at least be a comment.