Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interior mutability in mir predecessors cache #64736

Merged
merged 47 commits into from
Dec 2, 2019
Merged

Remove interior mutability in mir predecessors cache #64736

merged 47 commits into from
Dec 2, 2019

Commits on Dec 2, 2019

  1. Remove interior mutability in mir predecessors cache

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c16ef6b View commit details
    Browse the repository at this point in the history

  2. Inline cache impl into Body, rename predecessor fns, change output of… 

    … predecessors_for to slice
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    b524059 View commit details
    Browse the repository at this point in the history

  3. Get rid of old comment

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    ce29f43 View commit details
    Browse the repository at this point in the history

  4. Stop invalidating predecessors cache when accessing unique basic bloc… 

    …k, invalidate cache when accessing unique terminator
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    f534d9f View commit details
    Browse the repository at this point in the history

  5. Add pass to ensure predecessors cache is generated after optimization

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    2b31456 View commit details
    Browse the repository at this point in the history

  6. Fix Mir visitor macro to ensure it calls the proper method to invalid… 

    …ate the predecessors cache
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    e1afa51 View commit details
    Browse the repository at this point in the history

  7. Address linting errors caught by CI

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    570e418 View commit details
    Browse the repository at this point in the history

  8. Ensure predecessors are recomputed at critical points, fixes panics

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    8e8c97e View commit details
    Browse the repository at this point in the history

  9. Move predecessors cache invalidation back to basic_blocks_mut, add a … 

    …couple more ensure_predecessors to prevent panics
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    ad73468 View commit details
    Browse the repository at this point in the history

  10. Address excessive line length that was triggering warning during linting

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    94414ac View commit details
    Browse the repository at this point in the history

  11. Address nits and remove unneeded pass

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    52cc85f View commit details
    Browse the repository at this point in the history

  12. Add back cache invalidation to basic_blocks_and_local_decls_mut

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    22bc8a0 View commit details
    Browse the repository at this point in the history

  13. Move predecessors cache back to its own type 

    This ensures that the cache can be properly ignored during encoding and decoding.
Fix panics that arose due to lack of encoding
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    9b335ce View commit details
    Browse the repository at this point in the history

  14. Move predecessor cache outside of Body, use wrapper types to manage C… 

    …ache and Body (WIP, amend this commit)
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c0592fa View commit details
    Browse the repository at this point in the history

  15. Simplify Cache wrapper to single type, impl Deref on it, fix all comp… 

    …ilation errors in librustc_codegen_ssa
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    649c73f View commit details
    Browse the repository at this point in the history

  16. Remove Body from FunctionCx, pass it along during librustc_codegen_ssa

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    30b1d9e View commit details
    Browse the repository at this point in the history

  17. Improved BodyCache body impl so it only returns a sharable ref, add n… 

    …ew body_mut method, fix visit macros, simplify usage in codegen_ssa analyzer
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    3d68f5f View commit details
    Browse the repository at this point in the history

  18. Add Body back as field of FunctionCx, but under a different lifetime

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    16952cc View commit details
    Browse the repository at this point in the history

  19. Revert back to using FunctionCx's Body

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    66279d1 View commit details
    Browse the repository at this point in the history

  20. Convert &mut to & since the reference didn't need to be mutable

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c8c266a View commit details
    Browse the repository at this point in the history

  21. Account for new maybe_sideeffect helper that requires predecessors

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    2eed90a View commit details
    Browse the repository at this point in the history

  22. Fix a large number of Body -> (ReadOnly)BodyCache type errors, add pr… 

    …edecessor_locations fn to ReadOnlyBodyCache
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    ab98c59 View commit details
    Browse the repository at this point in the history

  23. Add read_only fn to BodyCache<&mut...> impl, fix more Body -> (ReadOn… 

    …ly)BodyCache type errors
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    26f1c01 View commit details
    Browse the repository at this point in the history

  24. Add predecessors fn to ReadOnlyBodyCache, fix more Body -> (ReadOnly)… 

    …BodyCache type errors
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    0a19371 View commit details
    Browse the repository at this point in the history

  25. Fix typo caused by rebasing

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    3642a71 View commit details
    Browse the repository at this point in the history

  26. Fix remaining Body -> (ReadOnly)BodyCache type errors in librustc_mir… 

    … outside of librustc_mir/transform
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    38c0887 View commit details
    Browse the repository at this point in the history

  27. Simplify BodyCache impl and fix all remaining type errors in librustc… 

    …_mir (lifetime errors still exist)
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    fc6b58d View commit details
    Browse the repository at this point in the history

  28. Fix remaining compilation issues

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    4de31b2 View commit details
    Browse the repository at this point in the history

  29. Fix typos caused during rebase

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    35590b5 View commit details
    Browse the repository at this point in the history

  30. Fix tidy errors

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    67b7a78 View commit details
    Browse the repository at this point in the history

  31. Fix typo

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    ab657e3 View commit details
    Browse the repository at this point in the history

  32. Fix compilation errors created during rebase

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    e54c610 View commit details
    Browse the repository at this point in the history

  33. Undo minor changes that weren't needed, fix one lifetime typo

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c42bdb8 View commit details
    Browse the repository at this point in the history

  34. Remove BodyCache.body and rely on Deref as much as possible for ReadO… 

    …nlyBodyCache
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    595d161 View commit details
    Browse the repository at this point in the history

  35. Remove HasLocalDecls impl from BodyCache's, properly reborrow to Body… 

    …, rename all body_cache back to body
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    b2fe254 View commit details
    Browse the repository at this point in the history

  36. Fix typos caused during rebase

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    51b0665 View commit details
    Browse the repository at this point in the history

  37. Remove files created during conflict resolution

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    ed90818 View commit details
    Browse the repository at this point in the history

  38. Compute predecessors in mir_build query and use existing cache for ge… 

    …nerating ReadOnlyBodyCache, remove unneeded fns
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    05dc5e9 View commit details
    Browse the repository at this point in the history

  39. Fix type errors cause during rebasing

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    245abc4 View commit details
    Browse the repository at this point in the history

  40. Remove inline attributes that hadn't been profiled, unexport Cache si… 

    …nce it no longer needs to be public
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c6354e9 View commit details
    Browse the repository at this point in the history

  41. Remove unchecked inline attribute, remove unused functions, make chac… 

    …he mod private again
    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    598797c View commit details
    Browse the repository at this point in the history

  42. Fix type errors created during rebasing

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    64654ce View commit details
    Browse the repository at this point in the history

  43. Fix rebasing errors, convert some BodyCache::body() calls to reborrows

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    9978574 View commit details
    Browse the repository at this point in the history

  44. Fix tidy issues

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    acb90eb View commit details
    Browse the repository at this point in the history

  45. Use new HashStable proc macro

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    38bd3a2 View commit details
    Browse the repository at this point in the history

  46. Fix issues caused during rebasing

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    6123478 View commit details
    Browse the repository at this point in the history

  47. Fix issues caused during rebasing

    @Nashenas88
    Nashenas88 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    3eaad56 View commit details
    Browse the repository at this point in the history