Rollup of 7 pull requests

[Centril]

Successful merges:

• Do not emit JSON dumps of diagnostic codes #63721 (Do not emit JSON dumps of diagnostic codes)
• update Miri #63747 (update Miri)
• Bump toml dependency. #63753 (Bump toml dependency.)
• Use dedicated type for spans in pre-expansion gating. #63755 (Use dedicated type for spans in pre-expansion gating.)
• Allow 'default async fn' to parse. #63759 (Allow 'default async fn' to parse.)
• Update books #63760 (Update books)
• async_await was stabilized in 1.39.0, not 1.38.0. #63762 (async_await was stabilized in 1.39.0, not 1.38.0.)

Failed merges:

r? @ghost

[Centril]

@bors r+ p=7 rollup=never

[bors]

📌 Commit cbf92ee has been approved by Centril

[bors]

⌛ Testing commit cbf92ee with merge 0a87bfd728a57793bb5e39a23ea15a6cedfe7c3c...

[rust-highfive]

The job LinuxTools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-20T22:26:51.0115955Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-20T22:26:51.0320321Z ##[command]git config gc.auto 0
2019-08-20T22:26:51.0394740Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-20T22:26:51.0464627Z ##[command]git config --get-all http.proxy
2019-08-20T22:26:51.0622993Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63763/merge:refs/remotes/pull/63763/merge
---
2019-08-20T22:27:25.2310269Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-20T22:27:25.2310454Z 
2019-08-20T22:27:25.2310826Z   git checkout -b <new-branch-name>
2019-08-20T22:27:25.2310986Z 
2019-08-20T22:27:25.2311163Z HEAD is now at bc4b90d7f Merge cbf92ee636f23f4ca4f7eaffec3d55716abf8c6f into bea0372a1a7a31b81f28cc4d9a83a2dc9a79d008
2019-08-20T22:27:25.2456923Z ##[section]Finishing: Checkout
2019-08-20T22:27:25.2466298Z ##[section]Starting: Decide whether to run this job
2019-08-20T22:27:25.2470019Z Task         : Bash
2019-08-20T22:27:25.2470066Z Description  : Run a Bash script on macOS, Linux, or Windows
2019-08-20T22:27:25.2470129Z Version      : 3.151.3
2019-08-20T22:27:25.2470193Z Author       : Microsoft Corporation
2019-08-20T22:27:25.2470193Z Author       : Microsoft Corporation
2019-08-20T22:27:25.2470244Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
2019-08-20T22:27:25.2470294Z ==============================================================================
2019-08-20T22:27:25.3889521Z Generating script.
2019-08-20T22:27:25.3930191Z ========================== Starting Command Output ===========================
2019-08-20T22:27:25.3961837Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/88c903c8-050b-40d9-98b0-2ea5836242d9.sh
2019-08-20T22:27:25.5424507Z Executing the job since submodules are updated
2019-08-20T22:27:25.5465492Z ##[section]Finishing: Decide whether to run this job
2019-08-20T22:27:25.5476177Z ==============================================================================
2019-08-20T22:27:25.5476410Z Task         : Bash
2019-08-20T22:27:25.5476456Z Description  : Run a Bash script on macOS, Linux, or Windows
2019-08-20T22:27:25.5476545Z Version      : 3.151.3
---
2019-08-21T00:40:39.4620219Z 
2019-08-21T00:40:39.4620467Z ------------------------------------------
2019-08-21T00:40:39.4620514Z stderr:
2019-08-21T00:40:39.4620738Z ------------------------------------------
2019-08-21T00:40:39.4621871Z {"message":"the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/issue_4266.rs","byte_start":44,"byte_end":55,"line_start":2,"line_end":2,"column_start":12,"column_end":23,"is_primary":true,"text":[{"text":"#![feature(async_await)]","highlight_start":12,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D stable-features` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable\n  --> tests/ui/issue_4266.rs:2:12\n   |\nLL | #![feature(async_await)]\n   |            ^^^^^^^^^^^\n   |\n   = note: `-D stable-features` implied by `-D warnings`\n\n"}
2019-08-21T00:40:39.4623870Z {"message":"explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)","code":{"code":"clippy::needless_lifetimes","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/issue_4266.rs","byte_start":80,"byte_end":113,"line_start":5,"line_end":5,"column_start":1,"column_end":34,"is_primary":true,"text":[{"text":"async fn sink1<'a>(_: &'a str) {} // lint","highlight_start":1,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::needless-lifetimes` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)\n  --> tests/ui/issue_4266.rs:5:1\n   |\nLL | async fn sink1<'a>(_: &'a str) {} // lint\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`\n\n"}
2019-08-21T00:40:39.4627037Z {"message":"explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)","code":{"code":"clippy::needless_lifetimes","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/issue_4266.rs","byte_start":171,"byte_end":227,"line_start":9,"line_end":11,"column_start":1,"column_end":2,"is_primary":true,"text":[{"text":"async fn one_to_one<'a>(s: &'a str) -> &'a str {","highlight_start":1,"highlight_end":49},{"text":"    s","highlight_start":1,"highlight_end":6},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)\n  --> tests/ui/issue_4266.rs:9:1\n   |\nLL | / async fn one_to_one<'a>(s: &'a str) -> &'a str {\nLL | |     s\nLL | | }\n   | |_^\n\n"}
2019-08-21T00:40:39.4627289Z 
2019-08-21T00:40:39.4627611Z ------------------------------------------
2019-08-21T00:40:39.4627644Z 
2019-08-21T00:40:39.4627994Z thread '[ui] ui/issue_4266.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
---
2019-08-21T00:40:39.4689615Z 
2019-08-21T00:40:39.4689835Z ------------------------------------------
2019-08-21T00:40:39.4689897Z stderr:
2019-08-21T00:40:39.4690108Z ------------------------------------------
2019-08-21T00:40:39.4691408Z {"message":"the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":76,"byte_end":87,"line_start":4,"line_end":4,"column_start":12,"column_end":23,"is_primary":true,"text":[{"text":"#![feature(async_await)]","highlight_start":12,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D stable-features` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable\n  --> tests/ui/methods.rs:4:12\n   |\nLL | #![feature(async_await)]\n   |            ^^^^^^^^^^^\n   |\n   = note: `-D stable-features` implied by `-D warnings`\n\n"}
2019-08-21T00:40:39.4693732Z {"message":"defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name","code":{"code":"clippy::should_implement_trait","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":845,"byte_end":897,"line_start":37,"line_end":39,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    pub fn add(self, other: T) -> T {","highlight_start":5,"highlight_end":38},{"text":"        self","highlight_start":1,"highlight_end":13},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::should-implement-trait` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name\n  --> tests/ui/methods.rs:37:5\n   |\nLL | /     pub fn add(self, other: T) -> T {\nLL | |         self\nLL | |     }\n   | |_____^\n   |\n   = note: `-D clippy::should-implement-trait` implied by `-D warnings`\n\n"}
2019-08-21T00:40:39.4695169Z {"message":"methods called `new` usually return `Self`","code":{"code":"clippy::new_ret_no_self","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":2661,"byte_end":2694,"line_start":153,"line_end":155,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    fn new() -> i32 {","highlight_start":5,"highlight_end":22},{"text":"        0","highlight_start":1,"highlight_end":10},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::new-ret-no-self` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: methods called `new` usually return `Self`\n  --> tests/ui/methods.rs:153:5\n   |\nLL | /     fn new() -> i32 {\nLL | |         0\nLL | |     }\n   | |_____^\n   |\n   = note: `-D clippy::new-ret-no-self` implied by `-D warnings`\n\n"}
2019-08-21T00:40:39.4697350Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3073,"byte_end":3196,"line_start":175,"line_end":177,"column_start":13,"column_end":29,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"                // Should lint even though this call is on a separate line.","highlight_start":1,"highlight_end":76},{"text":"               .unwrap_or(0);","highlight_start":1,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::option-map-unwrap-or` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:175:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                 // Should lint even though this call is on a separate line.\nLL | |                .unwrap_or(0);\n   | |____________________________^\n   |\n   = note: `-D clippy::option-map-unwrap-or` implied by `-D warnings`\n   = note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`\n\n"}
2019-08-21T00:40:39.4698831Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3235,"byte_end":3329,"line_start":179,"line_end":182,"column_start":13,"column_end":29,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| {","highlight_start":13,"highlight_end":26},{"text":"                        x + 1","highlight_start":1,"highlight_end":30},{"text":"                    }","highlight_start":1,"highlight_end":22},{"text":"              ).unwrap_or(0);","highlight_start":1,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:179:13\n   |\nLL |       let _ = opt.map(|x| {\n   |  _____________^\nLL | |                         x + 1\nLL | |                     }\nLL | |               ).unwrap_or(0);\n   | |____________________________^\n\n"}
2019-08-21T00:40:39.4700205Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3343,"byte_end":3430,"line_start":183,"line_end":186,"column_start":13,"column_end":19,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"               .unwrap_or({","highlight_start":1,"highlight_end":28},{"text":"                    0","highlight_start":1,"highlight_end":22},{"text":"                });","highlight_start":1,"highlight_end":19}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:183:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                .unwrap_or({\nLL | |                     0\nLL | |                 });\n   | |__________________^\n\n"}
2019-08-21T00:40:39.4701494Z {"message":"called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3494,"byte_end":3534,"line_start":188,"line_end":188,"column_start":13,"column_end":53,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);","highlight_start":13,"highlight_end":53}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead\n  --> tests/ui/methods.rs:188:13\n   |\nLL |     let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`\n\n"}
2019-08-21T00:40:39.4703908Z {"message":"called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3598,"byte_end":3659,"line_start":190,"line_end":193,"column_start":13,"column_end":22,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| {","highlight_start":13,"highlight_end":26},{"text":"        Some(x + 1)","highlight_start":1,"highlight_end":20},{"text":"    }","highlight_start":1,"highlight_end":6},{"text":"    ).unwrap_or(None);","highlight_start":1,"highlight_end":22}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead\n  --> tests/ui/methods.rs:190:13\n   |\nLL |       let _ = opt.map(|x| {\n   |  _____________^\nLL | |         Some(x + 1)\nLL | |     }\nLL | |     ).unwrap_or(None);\n   | |_____________________^\n\n"}
2019-08-21T00:40:39.4705669Z {"message":"called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3673,"byte_end":3731,"line_start":194,"line_end":196,"column_start":13,"column_end":25,"is_primary":true,"text":[{"text":"    let _ = opt","highlight_start":13,"highlight_end":16},{"text":"        .map(|x| Some(x + 1))","highlight_start":1,"highlight_end":30},{"text":"        .unwrap_or(None);","highlight_start":1,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead\n  --> tests/ui/methods.rs:194:13\n   |\nLL |       let _ = opt\n   |  _____________^\nLL | |         .map(|x| Some(x + 1))\nLL | |         .unwrap_or(None);\n   | |________________________^\n   |\n   = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`\n\n"}
2019-08-21T00:40:39.4707258Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4117,"byte_end":4172,"line_start":205,"line_end":205,"column_start":13,"column_end":68,"is_primary":true,"text":[{"text":"    let _ = Some(\"prefix\").map(|p| format!(\"{}.\", p)).unwrap_or(id);","highlight_start":13,"highlight_end":68}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `map(|p| format!(\"{}.\", p)).unwrap_or(id)` with `map_or(id, |p| format!(\"{}.\", p))`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:205:13\n   |\nLL |     let _ = Some(\"prefix\").map(|p| format!(\"{}.\", p)).unwrap_or(id);\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `map(|p| format!(\"{}.\", p)).unwrap_or(id)` with `map_or(id, |p| format!(\"{}.\", p))`\n\n"}
2019-08-21T00:40:39.4709409Z {"message":"called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead","code":{"code":"clippy::option_map_unwrap_or_else","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4250,"byte_end":4381,"line_start":209,"line_end":211,"column_start":13,"column_end":37,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"                // Should lint even though this call is on a separate line.","highlight_start":1,"highlight_end":76},{"text":"               .unwrap_or_else(|| 0);","highlight_start":1,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::option-map-unwrap-or-else` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead\n  --> tests/ui/methods.rs:209:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                 // Should lint even though this call is on a separate line.\nLL | |                .unwrap_or_else(|| 0);\n   | |____________________________________^\n   |\n   = note: `-D clippy::option-map-unwrap-or-else` implied by `-D warnings`\n   = note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`\n\n"}
2019-08-21T00:40:39.4711581Z {"message":"called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead","code":{"code":"clippy::option_map_unwrap_or_else","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4420,"byte_end":4522,"line_start":213,"line_end":216,"column_start":13,"column_end":37,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| {","highlight_start":13,"highlight_end":26},{"text":"                        x + 1","highlight_start":1,"highlight_end":30},{"text":"                    }","highlight_start":1,"highlight_end":22},{"text":"              ).unwrap_or_else(|| 0);","highlight_start":1,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead\n  --> tests/ui/methods.rs:213:13\n   |\nLL |       let _ = opt.map(|x| {\n   |  _____________^\nLL | |                         x + 1\nLL | |                     }\nLL | |               ).unwrap_or_else(|| 0);\n   | |____________________________________^\n\n"}
2019-08-21T00:40:39.4713824Z {"message":"called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead","code":{"code":"clippy::option_map_unwrap_or_else","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4536,"byte_end":4628,"line_start":217,"line_end":220,"column_start":13,"column_end":18,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"               .unwrap_or_else(||","highlight_start":1,"highlight_end":34},{"text":"                    0","highlight_start":1,"highlight_end":22},{"text":"                );","highlight_start":1,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead\n  --> tests/ui/methods.rs:217:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                .unwrap_or_else(||\nLL | |                     0\nLL | |                 );\n   | |_________________^\n\n"}
2019-08-21T00:40:39.4715516Z {"message":"called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.","code":{"code":"clippy::filter_next","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5228,"byte_end":5263,"line_start":247,"line_end":247,"column_start":13,"column_end":48,"is_primary":true,"text":[{"text":"    let _ = v.iter().filter(|&x| *x < 0).next();","highlight_start":13,"highlight_end":48}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::filter-next` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.\n  --> tests/ui/methods.rs:247:13\n   |\nLL |     let _ = v.iter().filter(|&x| *x < 0).next();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::filter-next` implied by `-D warnings`\n   = note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`\n\n"}
2019-08-21T00:40:39.4717104Z {"message":"called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.","code":{"code":"clippy::filter_next","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5302,"byte_end":5421,"line_start":250,"line_end":253,"column_start":13,"column_end":28,"is_primary":true,"text":[{"text":"    let _ = v.iter().filter(|&x| {","highlight_start":13,"highlight_end":35},{"text":"                                *x < 0","highlight_start":1,"highlight_end":39},{"text":"                            }","highlight_start":1,"highlight_end":30},{"text":"                   ).next();","highlight_start":1,"highlight_end":28}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.\n  --> tests/ui/methods.rs:250:13\n   |\nLL |       let _ = v.iter().filter(|&x| {\n   |  _____________^\nLL | |                                 *x < 0\nLL | |                             }\nLL | |                    ).next();\n   | |___________________________^\n\n"}
2019-08-21T00:40:39.4719334Z {"message":"called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5778,"byte_end":5814,"line_start":266,"line_end":266,"column_start":13,"column_end":49,"is_primary":true,"text":[{"text":"    let _ = v.iter().find(|&x| *x < 0).is_some();","highlight_start":13,"highlight_end":49}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::search-is-some` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `find(|&x| *x < 0).is_some()` with `any(|x| *x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:266:13\n   |\nLL |     let _ = v.iter().find(|&x| *x < 0).is_some();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::search-is-some` implied by `-D warnings`\n   = note: replace `find(|&x| *x < 0).is_some()` with `any(|x| *x < 0)`\n\n"}
2019-08-21T00:40:39.4721037Z {"message":"called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5879,"byte_end":5995,"line_start":269,"line_end":272,"column_start":13,"column_end":31,"is_primary":true,"text":[{"text":"    let _ = v.iter().find(|&x| {","highlight_start":13,"highlight_end":33},{"text":"                              *x < 0","highlight_start":1,"highlight_end":37},{"text":"                          }","highlight_start":1,"highlight_end":28},{"text":"                   ).is_some();","highlight_start":1,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:269:13\n   |\nLL |       let _ = v.iter().find(|&x| {\n   |  _____________^\nLL | |                               *x < 0\nLL | |                           }\nLL | |                    ).is_some();\n   | |______________________________^\n\n"}
2019-08-21T00:40:39.4722722Z {"message":"called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6065,"byte_end":6104,"line_start":275,"line_end":275,"column_start":13,"column_end":52,"is_primary":true,"text":[{"text":"    let _ = v.iter().position(|&x| x < 0).is_some();","highlight_start":13,"highlight_end":52}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:275:13\n   |\nLL |     let _ = v.iter().position(|&x| x < 0).is_some();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`\n\n"}
2019-08-21T00:40:39.4724593Z {"message":"called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6173,"byte_end":6300,"line_start":278,"line_end":281,"column_start":13,"column_end":31,"is_primary":true,"text":[{"text":"    let _ = v.iter().position(|&x| {","highlight_start":13,"highlight_end":37},{"text":"                                  x < 0","highlight_start":1,"highlight_end":40},{"text":"                              }","highlight_start":1,"highlight_end":32},{"text":"                   ).is_some();","highlight_start":1,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:278:13\n   |\nLL |       let _ = v.iter().position(|&x| {\n   |  _____________^\nLL | |                                   x < 0\nLL | |                               }\nLL | |                    ).is_some();\n   | |______________________________^\n\n"}
2019-08-21T00:40:39.4726025Z {"message":"called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6371,"byte_end":6411,"line_start":284,"line_end":284,"column_start":13,"column_end":53,"is_primary":true,"text":[{"text":"    let _ = v.iter().rposition(|&x| x < 0).is_some();","highlight_start":13,"highlight_end":53}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:284:13\n   |\nLL |     let _ = v.iter().rposition(|&x| x < 0).is_some();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`\n\n"}
2019-08-21T00:40:39.4727737Z {"message":"called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6481,"byte_end":6611,"line_start":287,"line_end":290,"column_start":13,"column_end":31,"is_primary":true,"text":[{"text":"    let _ = v.iter().rposition(|&x| {","highlight_start":13,"highlight_end":38},{"text":"                                   x < 0","highlight_start":1,"highlight_end":41},{"text":"                               }","highlight_start":1,"highlight_end":33},{"text":"                   ).is_some();","highlight_start":1,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:287:13\n   |\nLL |       let _ = v.iter().rposition(|&x| {\n   |  _____________^\nLL | |                                    x < 0\nLL | |                                }\nLL | |                    ).is_some();\n   | |______________________________^\n\n"}
2019-08-21T00:40:39.4729136Z {"message":"used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message","code":{"code":"clippy::option_unwrap_used","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6924,"byte_end":6936,"line_start":302,"line_end":302,"column_start":13,"column_end":25,"is_primary":true,"text":[{"text":"    let _ = opt.unwrap();","highlight_start":13,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::option-unwrap-used` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message\n  --> tests/ui/methods.rs:302:13\n   |\nLL |     let _ = opt.unwrap();\n   |             ^^^^^^^^^^^^\n   |\n   = note: `-D clippy::option-unwrap-used` implied by `-D warnings`\n\n"}
2019-08-21T00:40:39.4729371Z 
2019-08-21T00:40:39.4729607Z ------------------------------------------
2019-08-21T00:40:39.4729640Z 
2019-08-21T00:40:39.4729985Z thread '[ui] ui/methods.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
---
2019-08-21T00:47:52.7804742Z    Compiling rustc-ap-syntax_pos v546.0.0
2019-08-21T00:48:08.1512977Z    Compiling rayon v1.1.0
2019-08-21T00:48:15.7952775Z    Compiling rustc-ap-rustc_errors v546.0.0
2019-08-21T00:53:59.9041982Z    Compiling racer v2.1.25
2019-08-21T00:58:22.7322784Z warning: use of deprecated item 'build::rustc::rustc_plugin': import this through `rustc_driver::plugin` instead to make TLS work correctly. See ***/issues/62717
2019-08-21T00:58:22.7324150Z    |
2019-08-21T00:58:22.7324476Z 18 | extern crate rustc_plugin;
2019-08-21T00:58:22.7324750Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-21T00:58:22.7325002Z    |
---
2019-08-21T01:03:02.9267440Z    Compiling tokio-udp v0.1.3
2019-08-21T01:03:04.9500630Z    Compiling tokio-uds v0.2.5
2019-08-21T01:03:08.4587699Z    Compiling tokio-process v0.2.3
2019-08-21T01:03:11.0189864Z    Compiling tokio v0.1.14
2019-08-21T01:03:15.9440226Z warning: use of deprecated item 'build::rustc::rustc_plugin': import this through `rustc_driver::plugin` instead to make TLS work correctly. See ***/issues/62717
2019-08-21T01:03:15.9440913Z    |
2019-08-21T01:03:15.9441257Z 18 | extern crate rustc_plugin;
2019-08-21T01:03:15.9441533Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-21T01:03:15.9441761Z    |
2019-08-21T01:03:15.9441761Z    |
2019-08-21T01:03:15.9442068Z    = note: `#[warn(deprecated)]` on by default
2019-08-21T01:03:15.9442109Z 
2019-08-21T01:03:24.8359985Z warning: use of deprecated item 'build::rustc::rustc_plugin': import this through `rustc_driver::plugin` instead to make TLS work correctly. See ***/issues/62717
2019-08-21T01:03:24.8361894Z    |
2019-08-21T01:03:24.8362521Z 18 | extern crate rustc_plugin;
2019-08-21T01:03:24.8363141Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-08-21T01:03:24.8363686Z    |
---
2019-08-21T01:20:12.2925340Z 
2019-08-21T01:20:12.2926076Z 
2019-08-21T01:20:12.2926142Z diff of stderr:
2019-08-21T01:20:12.2926169Z 
2019-08-21T01:20:12.2933969Z +warning: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable
2019-08-21T01:20:12.2934638Z + --> $DIR/async-fn.rs:1:12
2019-08-21T01:20:12.2934870Z +  |
2019-08-21T01:20:12.2954221Z +1 | #![feature(async_await, never_type)]
2019-08-21T01:20:12.2954384Z +  |            ^^^^^^^^^^^
2019-08-21T01:20:12.2954427Z +  |
2019-08-21T01:20:12.2954617Z +  = note: `#[warn(stable_features)]` on by default
2019-08-21T01:20:12.2954942Z +
2019-08-21T01:20:12.2954967Z 
2019-08-21T01:20:12.2955026Z The actual stderr differed from the expected stderr.
2019-08-21T01:20:12.2955026Z The actual stderr differed from the expected stderr.
2019-08-21T01:20:12.2955467Z Actual stderr saved to /tmp/compiletesti8ZJF1/async-fn.stderr
2019-08-21T01:20:12.2955521Z To update references, run this command from build directory:
2019-08-21T01:20:12.2955787Z tests/run-pass/update-references.sh '/tmp/compiletesti8ZJF1' 'async-fn.rs'
2019-08-21T01:20:12.2956005Z error: 1 errors occurred comparing output.
2019-08-21T01:20:12.2956048Z status: exit code: 0
2019-08-21T01:20:12.2956048Z status: exit code: 0
2019-08-21T01:20:12.2956614Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/async-fn.rs" "-L" "/tmp/compiletesti8ZJF1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletesti8ZJF1/async-fn.stage-id" "--edition" "2018" "--sysroot" "/home/user/.cache/miri/HOST" "-L" "/tmp/compiletesti8ZJF1/async-fn.stage-id.aux" "-A" "unused"
2019-08-21T01:20:12.2956930Z ------------------------------------------
2019-08-21T01:20:12.2956963Z 
2019-08-21T01:20:12.2957175Z ------------------------------------------
2019-08-21T01:20:12.2957217Z stderr:
2019-08-21T01:20:12.2957217Z stderr:
2019-08-21T01:20:12.2957438Z ------------------------------------------
2019-08-21T01:20:12.2958454Z {"message":"the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"warning","spans":[{"file_name":"tests/run-pass/async-fn.rs","byte_start":11,"byte_end":22,"line_start":1,"line_end":1,"column_start":12,"column_end":23,"is_primary":true,"text":[{"text":"#![feature(async_await, never_type)]","highlight_start":12,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`#[warn(stable_features)]` on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable\n --> tests/run-pass/async-fn.rs:1:12\n  |\n1 | #![feature(async_await, never_type)]\n  |            ^^^^^^^^^^^\n  |\n  = note: `#[warn(stable_features)]` on by default\n\n"}
2019-08-21T01:20:12.2959668Z ------------------------------------------
2019-08-21T01:20:12.2959705Z 
2019-08-21T01:20:12.2960077Z thread '[ui] run-pass/async-fn.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
2019-08-21T01:20:12.2960148Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
---
2019-08-21T01:20:34.2735488Z 
2019-08-21T01:20:34.2735606Z failures:
2019-08-21T01:20:34.2737550Z     [ui] run-pass/async-fn.rs
2019-08-21T01:20:34.2739620Z 
2019-08-21T01:20:34.2747015Z test result: FAILEDthread 'main' panicked at 'Some tests failed', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/lib.rs:. 164 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-08-21T01:20:34.2752322Z 90:22
2019-08-21T01:20:34.2827975Z error: test failed, to rerun pass '--test compiletest'
2019-08-21T01:20:34.2846437Z 
2019-08-21T01:20:34.2846552Z 
---
2019-08-21T01:20:34.3063877Z Verifying status of clippy-driver...
2019-08-21T01:20:34.3075779Z Verifying status of miri...
2019-08-21T01:20:34.3087926Z This PR updated 'src/tools/miri', verifying if status is 'test-pass'...
2019-08-21T01:20:34.3096818Z 
2019-08-21T01:20:34.3105885Z ⚠️ We detected that this PR updated 'miri', but its tests failed.
2019-08-21T01:20:34.3105988Z 
2019-08-21T01:20:34.3106341Z If you do intend to update 'miri', please check the error messages above and
2019-08-21T01:20:34.3106424Z commit another update.
2019-08-21T01:20:34.3106451Z 
2019-08-21T01:20:34.3106699Z If you do NOT intend to update 'miri', please ensure you did not accidentally
2019-08-21T01:20:34.3106992Z change the submodule at 'src/tools/miri'. You may ask your reviewer for the
2019-08-21T01:20:34.3107226Z proper steps.
2019-08-21T01:20:34.3118665Z   local time: Wed Aug 21 01:20:34 UTC 2019
2019-08-21T01:20:34.4697870Z   network time: Wed, 21 Aug 2019 01:20:34 GMT
2019-08-21T01:20:34.4697995Z == end clock drift check ==
2019-08-21T01:20:34.4697995Z == end clock drift check ==
2019-08-21T01:20:35.1464109Z ##[error]Bash exited with code '3'.
2019-08-21T01:20:35.1501885Z ##[section]Starting: Checkout
2019-08-21T01:20:35.1503997Z ==============================================================================
2019-08-21T01:20:35.1504057Z Task         : Get sources
2019-08-21T01:20:35.1504107Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[rust-highfive]

The job x86_64-gnu-tools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-21T00:03:14.6712290Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-21T00:03:14.6713584Z 
2019-08-21T00:03:14.6714920Z   git checkout -b <new-branch-name>
2019-08-21T00:03:14.6716794Z 
2019-08-21T00:03:14.6718017Z HEAD is now at 0a87bfd72 Auto merge of #63763 - Centril:rollup-8esag0j, r=Centril
2019-08-21T00:03:14.6913337Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-21T00:03:14.6916925Z ==============================================================================
2019-08-21T00:03:14.6917031Z Task         : Bash
2019-08-21T00:03:14.6917101Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-21T02:03:46.1697136Z 
2019-08-21T02:03:46.1697411Z ------------------------------------------
2019-08-21T02:03:46.1697502Z stderr:
2019-08-21T02:03:46.1697757Z ------------------------------------------
2019-08-21T02:03:46.1699310Z {"message":"the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/issue_4266.rs","byte_start":44,"byte_end":55,"line_start":2,"line_end":2,"column_start":12,"column_end":23,"is_primary":true,"text":[{"text":"#![feature(async_await)]","highlight_start":12,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D stable-features` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable\n  --> tests/ui/issue_4266.rs:2:12\n   |\nLL | #![feature(async_await)]\n   |            ^^^^^^^^^^^\n   |\n   = note: `-D stable-features` implied by `-D warnings`\n\n"}
2019-08-21T02:03:46.1700814Z {"message":"explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)","code":{"code":"clippy::needless_lifetimes","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/issue_4266.rs","byte_start":80,"byte_end":113,"line_start":5,"line_end":5,"column_start":1,"column_end":34,"is_primary":true,"text":[{"text":"async fn sink1<'a>(_: &'a str) {} // lint","highlight_start":1,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::needless-lifetimes` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)\n  --> tests/ui/issue_4266.rs:5:1\n   |\nLL | async fn sink1<'a>(_: &'a str) {} // lint\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`\n\n"}
2019-08-21T02:03:46.1702176Z {"message":"explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)","code":{"code":"clippy::needless_lifetimes","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/issue_4266.rs","byte_start":171,"byte_end":227,"line_start":9,"line_end":11,"column_start":1,"column_end":2,"is_primary":true,"text":[{"text":"async fn one_to_one<'a>(s: &'a str) -> &'a str {","highlight_start":1,"highlight_end":49},{"text":"    s","highlight_start":1,"highlight_end":6},{"text":"}","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)\n  --> tests/ui/issue_4266.rs:9:1\n   |\nLL | / async fn one_to_one<'a>(s: &'a str) -> &'a str {\nLL | |     s\nLL | | }\n   | |_^\n\n"}
2019-08-21T02:03:46.1702576Z 
2019-08-21T02:03:46.1702805Z ------------------------------------------
2019-08-21T02:03:46.1702840Z 
2019-08-21T02:03:46.1703145Z thread '[ui] ui/issue_4266.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
---
2019-08-21T02:03:46.1790723Z 
2019-08-21T02:03:46.1790913Z ------------------------------------------
2019-08-21T02:03:46.1790965Z stderr:
2019-08-21T02:03:46.1791149Z ------------------------------------------
2019-08-21T02:03:46.1792216Z {"message":"the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":76,"byte_end":87,"line_start":4,"line_end":4,"column_start":12,"column_end":23,"is_primary":true,"text":[{"text":"#![feature(async_await)]","highlight_start":12,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D stable-features` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable\n  --> tests/ui/methods.rs:4:12\n   |\nLL | #![feature(async_await)]\n   |            ^^^^^^^^^^^\n   |\n   = note: `-D stable-features` implied by `-D warnings`\n\n"}
2019-08-21T02:03:46.1793689Z {"message":"defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name","code":{"code":"clippy::should_implement_trait","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":845,"byte_end":897,"line_start":37,"line_end":39,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    pub fn add(self, other: T) -> T {","highlight_start":5,"highlight_end":38},{"text":"        self","highlight_start":1,"highlight_end":13},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::should-implement-trait` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name\n  --> tests/ui/methods.rs:37:5\n   |\nLL | /     pub fn add(self, other: T) -> T {\nLL | |         self\nLL | |     }\n   | |_____^\n   |\n   = note: `-D clippy::should-implement-trait` implied by `-D warnings`\n\n"}
2019-08-21T02:03:46.1795081Z {"message":"methods called `new` usually return `Self`","code":{"code":"clippy::new_ret_no_self","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":2661,"byte_end":2694,"line_start":153,"line_end":155,"column_start":5,"column_end":6,"is_primary":true,"text":[{"text":"    fn new() -> i32 {","highlight_start":5,"highlight_end":22},{"text":"        0","highlight_start":1,"highlight_end":10},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::new-ret-no-self` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: methods called `new` usually return `Self`\n  --> tests/ui/methods.rs:153:5\n   |\nLL | /     fn new() -> i32 {\nLL | |         0\nLL | |     }\n   | |_____^\n   |\n   = note: `-D clippy::new-ret-no-self` implied by `-D warnings`\n\n"}
2019-08-21T02:03:46.1798167Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3073,"byte_end":3196,"line_start":175,"line_end":177,"column_start":13,"column_end":29,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"                // Should lint even though this call is on a separate line.","highlight_start":1,"highlight_end":76},{"text":"               .unwrap_or(0);","highlight_start":1,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::option-map-unwrap-or` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:175:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                 // Should lint even though this call is on a separate line.\nLL | |                .unwrap_or(0);\n   | |____________________________^\n   |\n   = note: `-D clippy::option-map-unwrap-or` implied by `-D warnings`\n   = note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`\n\n"}
2019-08-21T02:03:46.1800496Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3235,"byte_end":3329,"line_start":179,"line_end":182,"column_start":13,"column_end":29,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| {","highlight_start":13,"highlight_end":26},{"text":"                        x + 1","highlight_start":1,"highlight_end":30},{"text":"                    }","highlight_start":1,"highlight_end":22},{"text":"              ).unwrap_or(0);","highlight_start":1,"highlight_end":29}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:179:13\n   |\nLL |       let _ = opt.map(|x| {\n   |  _____________^\nLL | |                         x + 1\nLL | |                     }\nLL | |               ).unwrap_or(0);\n   | |____________________________^\n\n"}
2019-08-21T02:03:46.1802041Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3343,"byte_end":3430,"line_start":183,"line_end":186,"column_start":13,"column_end":19,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"               .unwrap_or({","highlight_start":1,"highlight_end":28},{"text":"                    0","highlight_start":1,"highlight_end":22},{"text":"                });","highlight_start":1,"highlight_end":19}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:183:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                .unwrap_or({\nLL | |                     0\nLL | |                 });\n   | |__________________^\n\n"}
2019-08-21T02:03:46.1803892Z {"message":"called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3494,"byte_end":3534,"line_start":188,"line_end":188,"column_start":13,"column_end":53,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);","highlight_start":13,"highlight_end":53}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead\n  --> tests/ui/methods.rs:188:13\n   |\nLL |     let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`\n\n"}
2019-08-21T02:03:46.1806142Z {"message":"called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3598,"byte_end":3659,"line_start":190,"line_end":193,"column_start":13,"column_end":22,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| {","highlight_start":13,"highlight_end":26},{"text":"        Some(x + 1)","highlight_start":1,"highlight_end":20},{"text":"    }","highlight_start":1,"highlight_end":6},{"text":"    ).unwrap_or(None);","highlight_start":1,"highlight_end":22}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead\n  --> tests/ui/methods.rs:190:13\n   |\nLL |       let _ = opt.map(|x| {\n   |  _____________^\nLL | |         Some(x + 1)\nLL | |     }\nLL | |     ).unwrap_or(None);\n   | |_____________________^\n\n"}
2019-08-21T02:03:46.1808560Z {"message":"called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":3673,"byte_end":3731,"line_start":194,"line_end":196,"column_start":13,"column_end":25,"is_primary":true,"text":[{"text":"    let _ = opt","highlight_start":13,"highlight_end":16},{"text":"        .map(|x| Some(x + 1))","highlight_start":1,"highlight_end":30},{"text":"        .unwrap_or(None);","highlight_start":1,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead\n  --> tests/ui/methods.rs:194:13\n   |\nLL |       let _ = opt\n   |  _____________^\nLL | |         .map(|x| Some(x + 1))\nLL | |         .unwrap_or(None);\n   | |________________________^\n   |\n   = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`\n\n"}
2019-08-21T02:03:46.1810669Z {"message":"called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead","code":{"code":"clippy::option_map_unwrap_or","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4117,"byte_end":4172,"line_start":205,"line_end":205,"column_start":13,"column_end":68,"is_primary":true,"text":[{"text":"    let _ = Some(\"prefix\").map(|p| format!(\"{}.\", p)).unwrap_or(id);","highlight_start":13,"highlight_end":68}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `map(|p| format!(\"{}.\", p)).unwrap_or(id)` with `map_or(id, |p| format!(\"{}.\", p))`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead\n  --> tests/ui/methods.rs:205:13\n   |\nLL |     let _ = Some(\"prefix\").map(|p| format!(\"{}.\", p)).unwrap_or(id);\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `map(|p| format!(\"{}.\", p)).unwrap_or(id)` with `map_or(id, |p| format!(\"{}.\", p))`\n\n"}
2019-08-21T02:03:46.1813198Z {"message":"called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead","code":{"code":"clippy::option_map_unwrap_or_else","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4250,"byte_end":4381,"line_start":209,"line_end":211,"column_start":13,"column_end":37,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"                // Should lint even though this call is on a separate line.","highlight_start":1,"highlight_end":76},{"text":"               .unwrap_or_else(|| 0);","highlight_start":1,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::option-map-unwrap-or-else` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead\n  --> tests/ui/methods.rs:209:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                 // Should lint even though this call is on a separate line.\nLL | |                .unwrap_or_else(|| 0);\n   | |____________________________________^\n   |\n   = note: `-D clippy::option-map-unwrap-or-else` implied by `-D warnings`\n   = note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`\n\n"}
2019-08-21T02:03:46.1815259Z {"message":"called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead","code":{"code":"clippy::option_map_unwrap_or_else","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4420,"byte_end":4522,"line_start":213,"line_end":216,"column_start":13,"column_end":37,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| {","highlight_start":13,"highlight_end":26},{"text":"                        x + 1","highlight_start":1,"highlight_end":30},{"text":"                    }","highlight_start":1,"highlight_end":22},{"text":"              ).unwrap_or_else(|| 0);","highlight_start":1,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead\n  --> tests/ui/methods.rs:213:13\n   |\nLL |       let _ = opt.map(|x| {\n   |  _____________^\nLL | |                         x + 1\nLL | |                     }\nLL | |               ).unwrap_or_else(|| 0);\n   | |____________________________________^\n\n"}
2019-08-21T02:03:46.1817885Z {"message":"called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead","code":{"code":"clippy::option_map_unwrap_or_else","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":4536,"byte_end":4628,"line_start":217,"line_end":220,"column_start":13,"column_end":18,"is_primary":true,"text":[{"text":"    let _ = opt.map(|x| x + 1)","highlight_start":13,"highlight_end":31},{"text":"               .unwrap_or_else(||","highlight_start":1,"highlight_end":34},{"text":"                    0","highlight_start":1,"highlight_end":22},{"text":"                );","highlight_start":1,"highlight_end":18}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead\n  --> tests/ui/methods.rs:217:13\n   |\nLL |       let _ = opt.map(|x| x + 1)\n   |  _____________^\nLL | |                .unwrap_or_else(||\nLL | |                     0\nLL | |                 );\n   | |_________________^\n\n"}
2019-08-21T02:03:46.1820012Z {"message":"called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.","code":{"code":"clippy::filter_next","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5228,"byte_end":5263,"line_start":247,"line_end":247,"column_start":13,"column_end":48,"is_primary":true,"text":[{"text":"    let _ = v.iter().filter(|&x| *x < 0).next();","highlight_start":13,"highlight_end":48}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::filter-next` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.\n  --> tests/ui/methods.rs:247:13\n   |\nLL |     let _ = v.iter().filter(|&x| *x < 0).next();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::filter-next` implied by `-D warnings`\n   = note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`\n\n"}
2019-08-21T02:03:46.1821762Z {"message":"called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.","code":{"code":"clippy::filter_next","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5302,"byte_end":5421,"line_start":250,"line_end":253,"column_start":13,"column_end":28,"is_primary":true,"text":[{"text":"    let _ = v.iter().filter(|&x| {","highlight_start":13,"highlight_end":35},{"text":"                                *x < 0","highlight_start":1,"highlight_end":39},{"text":"                            }","highlight_start":1,"highlight_end":30},{"text":"                   ).next();","highlight_start":1,"highlight_end":28}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.\n  --> tests/ui/methods.rs:250:13\n   |\nLL |       let _ = v.iter().filter(|&x| {\n   |  _____________^\nLL | |                                 *x < 0\nLL | |                             }\nLL | |                    ).next();\n   | |___________________________^\n\n"}
2019-08-21T02:03:46.1823426Z {"message":"called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5778,"byte_end":5814,"line_start":266,"line_end":266,"column_start":13,"column_end":49,"is_primary":true,"text":[{"text":"    let _ = v.iter().find(|&x| *x < 0).is_some();","highlight_start":13,"highlight_end":49}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::search-is-some` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"replace `find(|&x| *x < 0).is_some()` with `any(|x| *x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:266:13\n   |\nLL |     let _ = v.iter().find(|&x| *x < 0).is_some();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: `-D clippy::search-is-some` implied by `-D warnings`\n   = note: replace `find(|&x| *x < 0).is_some()` with `any(|x| *x < 0)`\n\n"}
2019-08-21T02:03:46.1825009Z {"message":"called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":5879,"byte_end":5995,"line_start":269,"line_end":272,"column_start":13,"column_end":31,"is_primary":true,"text":[{"text":"    let _ = v.iter().find(|&x| {","highlight_start":13,"highlight_end":33},{"text":"                              *x < 0","highlight_start":1,"highlight_end":37},{"text":"                          }","highlight_start":1,"highlight_end":28},{"text":"                   ).is_some();","highlight_start":1,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:269:13\n   |\nLL |       let _ = v.iter().find(|&x| {\n   |  _____________^\nLL | |                               *x < 0\nLL | |                           }\nLL | |                    ).is_some();\n   | |______________________________^\n\n"}
2019-08-21T02:03:46.1827532Z {"message":"called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6065,"byte_end":6104,"line_start":275,"line_end":275,"column_start":13,"column_end":52,"is_primary":true,"text":[{"text":"    let _ = v.iter().position(|&x| x < 0).is_some();","highlight_start":13,"highlight_end":52}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:275:13\n   |\nLL |     let _ = v.iter().position(|&x| x < 0).is_some();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`\n\n"}
2019-08-21T02:03:46.1829795Z {"message":"called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6173,"byte_end":6300,"line_start":278,"line_end":281,"column_start":13,"column_end":31,"is_primary":true,"text":[{"text":"    let _ = v.iter().position(|&x| {","highlight_start":13,"highlight_end":37},{"text":"                                  x < 0","highlight_start":1,"highlight_end":40},{"text":"                              }","highlight_start":1,"highlight_end":32},{"text":"                   ).is_some();","highlight_start":1,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:278:13\n   |\nLL |       let _ = v.iter().position(|&x| {\n   |  _____________^\nLL | |                                   x < 0\nLL | |                               }\nLL | |                    ).is_some();\n   | |______________________________^\n\n"}
2019-08-21T02:03:46.1831314Z {"message":"called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6371,"byte_end":6411,"line_start":284,"line_end":284,"column_start":13,"column_end":53,"is_primary":true,"text":[{"text":"    let _ = v.iter().rposition(|&x| x < 0).is_some();","highlight_start":13,"highlight_end":53}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:284:13\n   |\nLL |     let _ = v.iter().rposition(|&x| x < 0).is_some();\n   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`\n\n"}
2019-08-21T02:03:46.1832941Z {"message":"called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.","code":{"code":"clippy::search_is_some","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6481,"byte_end":6611,"line_start":287,"line_end":290,"column_start":13,"column_end":31,"is_primary":true,"text":[{"text":"    let _ = v.iter().rposition(|&x| {","highlight_start":13,"highlight_end":38},{"text":"                                   x < 0","highlight_start":1,"highlight_end":41},{"text":"                               }","highlight_start":1,"highlight_end":33},{"text":"                   ).is_some();","highlight_start":1,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.\n  --> tests/ui/methods.rs:287:13\n   |\nLL |       let _ = v.iter().rposition(|&x| {\n   |  _____________^\nLL | |                                    x < 0\nLL | |                                }\nLL | |                    ).is_some();\n   | |______________________________^\n\n"}
2019-08-21T02:03:46.1834450Z {"message":"used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message","code":{"code":"clippy::option_unwrap_used","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/methods.rs","byte_start":6924,"byte_end":6936,"line_start":302,"line_end":302,"column_start":13,"column_end":25,"is_primary":true,"text":[{"text":"    let _ = opt.unwrap();","highlight_start":13,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::option-unwrap-used` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message\n  --> tests/ui/methods.rs:302:13\n   |\nLL |     let _ = opt.unwrap();\n   |             ^^^^^^^^^^^^\n   |\n   = note: `-D clippy::option-unwrap-used` implied by `-D warnings`\n\n"}
2019-08-21T02:03:46.1834909Z 
2019-08-21T02:03:46.1835136Z ------------------------------------------
2019-08-21T02:03:46.1835199Z 
2019-08-21T02:03:46.1836041Z thread '[ui] ui/methods.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
---
2019-08-21T02:31:30.0975791Z thread panicked while panicking. aborting.
2019-08-21T02:31:30.3258114Z [2019-08-21T02:31:30Z ERROR rls::server] Can't read message
2019-08-21T02:31:30.3263048Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }', src/libcore/result.rs:1084:5
2019-08-21T02:31:30.3263464Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-21T02:31:30.3264325Z error: process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/client-6870254cc3cde1fb` (signal: 4, SIGILL: illegal instruction)
2019-08-21T02:31:30.3276779Z 
2019-08-21T02:31:30.3277496Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rls/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--"
2019-08-21T02:31:30.3277653Z expected success, got: exit code: 101
2019-08-21T02:31:30.3277690Z 
---
2019-08-21T02:40:01.2138590Z 
2019-08-21T02:40:01.2138985Z 
2019-08-21T02:40:01.2145653Z diff of stderr:
2019-08-21T02:40:01.2145719Z 
2019-08-21T02:40:01.2145827Z +warning: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable
2019-08-21T02:40:01.2151399Z + --> $DIR/async-fn.rs:1:12
2019-08-21T02:40:01.2151493Z +  |
2019-08-21T02:40:01.2157809Z +1 | #![feature(async_await, never_type)]
2019-08-21T02:40:01.2157901Z +  |            ^^^^^^^^^^^
2019-08-21T02:40:01.2163852Z +  |
2019-08-21T02:40:01.2163962Z +  = note: `#[warn(stable_features)]` on by default
2019-08-21T02:40:01.2189092Z +
2019-08-21T02:40:01.2189119Z 
2019-08-21T02:40:01.2189186Z The actual stderr differed from the expected stderr.
2019-08-21T02:40:01.2189186Z The actual stderr differed from the expected stderr.
2019-08-21T02:40:01.2189561Z Actual stderr saved to /tmp/compiletestXj3BMc/async-fn.stderr
2019-08-21T02:40:01.2189650Z To update references, run this command from build directory:
2019-08-21T02:40:01.2189893Z tests/run-pass/update-references.sh '/tmp/compiletestXj3BMc' 'async-fn.rs'
2019-08-21T02:40:01.2190001Z error: 1 errors occurred comparing output.
2019-08-21T02:40:01.2190052Z status: exit code: 0
2019-08-21T02:40:01.2190052Z status: exit code: 0
2019-08-21T02:40:01.2190551Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/async-fn.rs" "-L" "/tmp/compiletestXj3BMc" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletestXj3BMc/async-fn.stage-id" "--edition" "2018" "--sysroot" "/home/user/.cache/miri/HOST" "-L" "/tmp/compiletestXj3BMc/async-fn.stage-id.aux" "-A" "unused"
2019-08-21T02:40:01.2190888Z ------------------------------------------
2019-08-21T02:40:01.2190940Z 
2019-08-21T02:40:01.2191115Z ------------------------------------------
2019-08-21T02:40:01.2191181Z stderr:
2019-08-21T02:40:01.2191181Z stderr:
2019-08-21T02:40:01.2191353Z ------------------------------------------
2019-08-21T02:40:01.2193258Z {"message":"the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"warning","spans":[{"file_name":"tests/run-pass/async-fn.rs","byte_start":11,"byte_end":22,"line_start":1,"line_end":1,"column_start":12,"column_end":23,"is_primary":true,"text":[{"text":"#![feature(async_await, never_type)]","highlight_start":12,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`#[warn(stable_features)]` on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: the feature `async_await` has been stable since 1.39.0 and no longer requires an attribute to enable\n --> tests/run-pass/async-fn.rs:1:12\n  |\n1 | #![feature(async_await, never_type)]\n  |            ^^^^^^^^^^^\n  |\n  = note: `#[warn(stable_features)]` on by default\n\n"}
2019-08-21T02:40:01.2193977Z ------------------------------------------
2019-08-21T02:40:01.2194044Z 
2019-08-21T02:40:01.2194435Z thread '[ui] run-pass/async-fn.rs' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/runtest.rs:2632:9
2019-08-21T02:40:01.2194569Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
---
2019-08-21T02:40:21.3933075Z Verifying status of clippy-driver...
2019-08-21T02:40:21.3946752Z Verifying status of miri...
2019-08-21T02:40:21.3964515Z This PR updated 'src/tools/miri', verifying if status is 'test-pass'...
2019-08-21T02:40:21.3975937Z 
2019-08-21T02:40:21.3978499Z ⚠️ We detected that this PR updated 'miri', but its tests failed.
2019-08-21T02:40:21.3980353Z 
2019-08-21T02:40:21.3980771Z If you do intend to update 'miri', please check the error messages above and
2019-08-21T02:40:21.3980844Z commit another update.
2019-08-21T02:40:21.3980897Z 
2019-08-21T02:40:21.3981129Z If you do NOT intend to update 'miri', please ensure you did not accidentally
2019-08-21T02:40:21.3981386Z change the submodule at 'src/tools/miri'. You may ask your reviewer for the
2019-08-21T02:40:21.3981619Z proper steps.
2019-08-21T02:40:21.3990264Z   local time: Wed Aug 21 02:40:21 UTC 2019
2019-08-21T02:40:21.6718986Z   network time: Wed, 21 Aug 2019 02:40:21 GMT
2019-08-21T02:40:21.6722936Z == end clock drift check ==
2019-08-21T02:40:21.6722936Z == end clock drift check ==
2019-08-21T02:40:22.3861036Z ##[error]Bash exited with code '3'.
2019-08-21T02:40:22.3899991Z ##[section]Starting: Upload CPU usage statistics
2019-08-21T02:40:22.3906771Z ==============================================================================
2019-08-21T02:40:22.3906880Z Task         : Bash
2019-08-21T02:40:22.3906952Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[bors]

💔 Test failed - checks-azure