Do not complain about unused code when used in impl Self type
#63317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
commented
Aug 6, 2019
|
|
||
| #![deny(dead_code)] | ||
|
|
||
| const TLC: usize = 4; |
There was a problem hiding this comment.
No complaint about TLC being unused
| } | ||
|
|
||
| struct X; | ||
| struct Y; |
There was a problem hiding this comment.
No complaint about Y being unused
estebank
commented
Aug 6, 2019
estebank
commented
Aug 6, 2019
| } | ||
|
|
||
| fn main() {} | ||
| fn main() { | ||
| let x = Foo::Bar(42); |
There was a problem hiding this comment.
This is added to remove the warning for Foo::Bar, not Foo.
estebank
commented
Aug 6, 2019
| @@ -5,12 +5,15 @@ | |||
| // when deriving Debug on an empty enum | |||
|
|
|||
| #[derive(Debug)] | |||
| enum Void {} //~ WARN never used | |||
| enum Void {} | |||
There was a problem hiding this comment.
This test is to verify that this doesn't emit a warning due to derive.
|
Ping from triage, @matthewjasper can you please review this. @estebank any updates after RalfJung last comment. Thanks. |
|
@bors r=matthewjasper |
|
📌 Commit 7def99a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 26, 2019
Do not complain about unused code when used in `impl` `Self` type Fix rust-lang#18290.
bors
added a commit
that referenced
this pull request
Aug 27, 2019
Rollup of 6 pull requests Successful merges: - #63317 (Do not complain about unused code when used in `impl` `Self` type) - #63693 (Fully implement or-pattern parsing) - #63836 (VxWorks does not provide a way to set the task name except at creation time) - #63845 (Removed a confusing FnOnce example) - #63855 (Refactor feature gates) - #63921 (add link to FileCheck docs) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18290.