Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #6279 (Windows uv build is busted) #6295

Merged
merged 2 commits into from
May 7, 2013
Merged

fix for #6279 (Windows uv build is busted) #6295

merged 2 commits into from
May 7, 2013

Conversation

yichoi
Copy link
Contributor

@yichoi yichoi commented May 7, 2013

fix for #6279 #6253

mk: rt.mk regression patch for mingw32 after #6176

currently do not pass optimization option just make it works only

mk: target.mk host.mk fix for duplicated rules of mingw32 after #6235

It can be simply fixed with CFG_LIB check whether bin or lib however considering multiple target triples with linux and windows, CFG_LIB needs to configurable #5223 and #5577

@brson
Copy link
Contributor

brson commented May 7, 2013

Thanks

bors added a commit that referenced this pull request May 7, 2013
fix for #6279 #6253

mk: rt.mk regression patch for mingw32 after #6176

currently do not pass optimization option just make it works only

mk: target.mk host.mk fix for duplicated rules of mingw32 after #6235

It can be simply fixed with CFG_LIB check whether bin or lib however considering multiple target triples with linux and windows, CFG_LIB needs to configurable #5223 and #5577
@bors bors closed this May 7, 2013
@bors bors merged commit 930908a into rust-lang:incoming May 7, 2013
@yichoi yichoi deleted the pull-mingw32 branch May 7, 2013 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants