Explicit error message for async recursion. #62871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@nikomatsakis thoughts on the extened error explanation? I made it simple enough that I'd be able to follow it. I'm tempted to put the link to the async book in the extended error info rather than directly in the error message as there's now two "For more info see" in the current message. |
|
r? @cramertj |
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Jul 22, 2019
|
r? @Centril since I already did a review... :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gilescope
force-pushed
the
async-recursion-error
branch
from
d1c1546
to
1effdd2
Compare
This comment has been minimized.
This comment has been minimized.
Centril
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
gilescope
force-pushed
the
async-recursion-error
branch
from
b7910c9
to
7c7f7a3
Compare
This comment has been minimized.
This comment has been minimized.
|
I seem to have managed to repro #57151 accidentally. Could some one kick bors and just confirm this is repeatable. If so will start digging... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gilescope
force-pushed
the
async-recursion-error
branch
from
e82c375
to
2c94203
Compare
This comment has been minimized.
This comment has been minimized.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 26, 2019
… r=Mark-Simulacrum error_index_generator should output stdout/stderr when it panics. **bootstrap change** Call error_index_generator tool using run_quiet which will additionally print std out and std err of the command when it returns an error. (was `run` uses `run_silent` under the covers.) Why: PR rust-lang#62871 is hitting a build error but the panic isn't getting shown so its unclear what the problem is.
This comment has been minimized.
This comment has been minimized.
gilescope
force-pushed
the
async-recursion-error
branch
from
2c94203
to
eaffe57
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gilescope
force-pushed
the
async-recursion-error
branch
from
eaffe57
to
d9969d0
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
gilescope
force-pushed
the
async-recursion-error
branch
from
d9969d0
to
4b1d404
Compare
|
Thanks @ollie27 for spotting that. Stick a fork in the PR - I think it's done. |
|
Indeed it is, thanks! @bors r+ |
|
📌 Commit 4b1d404 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 28, 2019
…Centril Explicit error message for async recursion. Attempt at clearer error message when async recusion is attempted. In response to rust-lang#62539 (and rust-lang#53690).
bors
added a commit
that referenced
this pull request
Jul 28, 2019
Rollup of 8 pull requests Successful merges: - #61856 (Lint attributes on function arguments) - #62360 (Document that ManuallyDrop::drop should not called more than once) - #62392 (Update minifier-rs version) - #62871 (Explicit error message for async recursion.) - #62995 (Avoid ICE when suggestion span is at Eof) - #63053 (SystemTime docs: recommend Instant for elapsed time) - #63081 (tidy: Cleanup the directory whitelist) - #63088 (Remove anonymous_parameters from unrelated test) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at clearer error message when async recusion is attempted. In response to #62539 (and #53690).