-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Miri #62823
update Miri #62823
Conversation
|
@bors r+ p=1 |
📌 Commit 24c86eb2e887d614d55a92c21a79745ee6d9d068 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r- Investigating |
I think my own PR broke Miri... |
I disabled the "overlaps" check in We can enable it again when we make progress on rust-lang/miri#785. |
This comment has been minimized.
This comment has been minimized.
Oh dang... some compile-fail tests are failing because they run against a libstd with debug assertions and that changes the error message. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
That CI failure is just #62811. Waiting for review for the |
👍 on the cfgs, but a comment would be nice |
We also need to include rust-lang/miri#849. |
Okay, let's see if PR-CI is happy... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
📌 Commit 10f877b has been approved by |
⌛ Testing commit 10f877b with merge 29198dac6e175eb7ee70f185995a4fe3f34829b4... |
⌛ Testing commit 10f877b with merge b6e0c7cc5fded2fdca5817cf32dc2e64309e082b... |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Not sure what that is... AWS complains or so? @bors retry |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-azure |
Tested on commit rust-lang/rust@299ef86. Direct link to PR: <rust-lang/rust#62823> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Fixes #62802
r? @oli-obk @eddyb