Refactor TinyList::contains and len to iterate instead of recurse
#62744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Ping from triage, any updates? @eddyb |
|
☔ The latest upstream changes (presumably #63207) made this pull request unmergeable. Please resolve the merge conflicts. |
llogiq
force-pushed
the
tiny-list-refactor
branch
from
6704bab
to
599cf2e
Compare
|
Rebased. |
eddyb
reviewed
Aug 9, 2019
llogiq
force-pushed
the
tiny-list-refactor
branch
from
599cf2e
to
8661a9c
Compare
eddyb
reviewed
Aug 13, 2019
eddyb
reviewed
Aug 13, 2019
llogiq
force-pushed
the
tiny-list-refactor
branch
from
8661a9c
to
45f14a8
Compare
|
@eddyb r? |
eddyb
added
S-waiting-on-author
|
I made the changes to the benchmarks as requested. @eddyb please clarify what is missing. |
|
📌 Commit 45f14a8 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 25, 2019
Refactor `TinyList::contains` and `len` to iterate instead of recurse None
bors
added a commit
that referenced
this pull request
Aug 25, 2019
Rollup of 6 pull requests Successful merges: - #62744 (Refactor `TinyList::contains` and `len` to iterate instead of recurse) - #63813 (Do not suggest `.try_into()` on `i32::from(x)`) - #63833 (Suggest calling closure with resolved return type when appropriate) - #63839 (Ensure miri can do bit ops on pointer values) - #63854 (Modifies how Arg, Arm, Field, FieldPattern and Variant are visited) - #63859 (Don't unwrap the result of `span_to_snippet`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.