Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polonius: fix some cases of killed fact generation, and most of the ui test suite #62736

Merged
merged 29 commits into from
Jul 25, 2019
Merged

Polonius: fix some cases of killed fact generation, and most of the ui test suite #62736

merged 29 commits into from
Jul 25, 2019

Commits on Jul 22, 2019

  1. Ignore NLL migrate mode test in the Polonius compare-mode 

    This is test specific to the NLL migrate mode which is irrelevant to -Z polonius.
It can't currently be encoded depending on migrate-mode and NLL/Polonius mode, so the NLL compare-mode also ignores it.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    c442dae View commit details
    Browse the repository at this point in the history

  2. Ignore test issue-45983 in the polonius compare mode 

    There is no difference between the NLL and Polonius outputs, and it manually tests NLLs.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    d4ca9a3 View commit details
    Browse the repository at this point in the history

  3. Ignore two-phase-reservation-sharing-interference-2.rs in Polonius co… 

    …mpare mode

This is just a difference from the test construction, it's ignore-compare-mode-nll and manually checks migrate/nll over edition2015/2018.

This failure is because the `migrate2015` and `migrate2018`  revisions are ran with `-Zpolonius`. There is no actual difference in the errors output by NLLs and Polonius.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    273bfd4 View commit details
    Browse the repository at this point in the history

  4. Ignore feature-gate-nll.rs in Polonius compare mode 

    This is a test about turning the NLL feature gate on, ignored by the NLL compare-mode.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    63c837e View commit details
    Browse the repository at this point in the history

  5. Ignore test issue-45696-scribble-on-boxed-borrow.rs in Polonius compa… 

    …re mode

Once again, the difference is in the test construction, it is ignored in compare-mode NLL and tested manually with revisions, and fails because the `migrate` revision is ran with `-Zpolonius`. There is no actual difference in the errors output by NLLs and Polonius.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    51c15fa View commit details
    Browse the repository at this point in the history

  6. Bless output of test ui/emit-artifact-notifications.rs for Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    ff350f8 View commit details
    Browse the repository at this point in the history

  7. Bless output of test save-analysis/emit-notifications.rs for Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    2824db1 View commit details
    Browse the repository at this point in the history

  8. Bless output of test nll/loan_ends_mid_block_pair.rs for Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    9410104 View commit details
    Browse the repository at this point in the history

  9. Bless output of test consts/promote_const_let.rs for Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    6a7c15e View commit details
    Browse the repository at this point in the history

  10. Bless output of test nll/get_default.rs for Polonius 

    2 of the 3 errors are "fixed by Polonius" 🎉
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    c5a1bc1 View commit details
    Browse the repository at this point in the history

  11. Bless output of test generator/ref-escapes-but-not-over-yield.rs for … 

    …Polonius
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    292d5c1 View commit details
    Browse the repository at this point in the history

  12. Bless output of test borrowck/borrowck-escaping-closure-error-2.rs fo… 

    …r Polonius
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    6fe5292 View commit details
    Browse the repository at this point in the history

  13. Bless output of test borrowck/two-phase-surprise-no-conflict.rs for P… 

    …olonius
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    7db61e7 View commit details
    Browse the repository at this point in the history

  14. Bless output of test dropck/dropck_trait_cycle_checked.rs for Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    08c25b5 View commit details
    Browse the repository at this point in the history

  15. Create a dedicated polonius test folder

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    9a82f52 View commit details
    Browse the repository at this point in the history

  16. Polonius facts: kill loans on Call terminators and StorageDead

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    6d9a4f9 View commit details
    Browse the repository at this point in the history

  17. Bless output of test borrowck/promote-ref-mut-in-let-issue-46557.rs f… 

    …or Polonius
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    0bd2b32 View commit details
    Browse the repository at this point in the history

  18. Ignore test hrtb/issue-30786.rs in Polonius compare mode

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    ed1625f View commit details
    Browse the repository at this point in the history

  19. Bless output of test nll/return-ref-mut-issue-46557.rs for Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    40e6b02 View commit details
    Browse the repository at this point in the history

  20. Add test extracted from rand, checking that StorageDead kills loans 

    Like "call-kills-loans", Polonius didn't know about some `killed` facts.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    9bd9b0d View commit details
    Browse the repository at this point in the history

  21. Rename test so that both "kills-loans" tests match names

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    606f798 View commit details
    Browse the repository at this point in the history

  22. Make both polonius loans tests check-pass

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    9e0fb6f View commit details
    Browse the repository at this point in the history

  23. Bless output of test unboxed-closures/unboxed-closures-failed-recursi… 

    …ve-fn-1.rs for Polonius
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    823ab42 View commit details
    Browse the repository at this point in the history

  24. Polonius: generate killed facts for assignments to projections

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    2f3e36f View commit details
    Browse the repository at this point in the history

  25. Add test checking various assignments are accepted in Polonius

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    d41e002 View commit details
    Browse the repository at this point in the history

  26. Add test to check that assignments to projections do not kill too man… 

    …y loans
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    770129c View commit details
    Browse the repository at this point in the history

  27. issue-46589 passes in Polonius and fails in NLL, duplicate it and man… 

    …ually check each outcome
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    c7f9a71 View commit details
    Browse the repository at this point in the history

  28. Bless output of test nll/loan_ends_mid_block_pair.rs for Polonius, again 

    Fixing assignments to projections made the Polonius output exactly the same as the NLL one.
    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    c0eab36 View commit details
    Browse the repository at this point in the history

  29. fix tidy

    @lqd
    lqd committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    e16bede View commit details
    Browse the repository at this point in the history