Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of small documentation fixes. #62720

Closed
wants to merge 3 commits into from
Closed

Couple of small documentation fixes. #62720

wants to merge 3 commits into from

Conversation

tomasz-rozanski
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2019
@shepmaster
Copy link
Member

Since you've moved the Unicode-related things to a new PR, you should remove them from this PR, leaving only the mut change. Go ahead and do that, squashing your commits, and we can merge this.

@tomasz-rozanski
Copy link
Contributor Author

Since you've moved the Unicode-related things to a new PR, you should remove them from this PR, leaving only the mut change. Go ahead and do that, squashing your commits, and we can merge this.

I'm not sure it's still possible, because I deleted this specific fork by mistake. Should I make a new PR in this case, or is there another way?

@shepmaster
Copy link
Member

I deleted this specific fork by mistake. Should I make a new PR in this case, or is there another way?

Huh, I'm surprised it's possible to delete a fork with open PRs. It appears that opening a new PR is the best alternative.

@tomasz-rozanski
Copy link
Contributor Author

I'll create a new PR, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants