Move FuzzyEq into core::cmp and rename it to ApproxEq #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
May 6, 2013
Moving the trait into `core` allows it to be added to the `num::Float` trait. I have also added and `assert_approx_eq!` macro. This is useful fo making approximate assertions on types that implement the `ApproxEq` trait. Examples: ~~~rust // using the default epsilon value assert_approx_eq!(1.0000001f, 1.0f); // using a custom epsilon value assert_approx_eq!(1.000001f, 1.0f, 1.0e-5); // fails with: "left: 1.00001 does not approximately equal right: 1" assert_approx_eq!(1.00001f, 1.0f); ~~~
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 3, 2020
use diff -u in driver.sh test this changs the add/delete indication from > > < to + + - (same as git diff) changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the trait into
coreallows it to be added to thenum::Floattrait.I have also added an
assert_approx_eq!macro. This is useful fo making approximate assertions on types that implement theApproxEqtrait.Examples: