Raise the default recursion limit to 128 #62450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
added
the
beta-nominated
rust-highfive
added
the
S-waiting-on-review
nagisa
added
T-compiler
|
Beta-nominated because low-risk and, I believe, the relevant regression has made its way into beta. I haven’t verified though. |
At least in IDE, one definitely wants to limit the amount of work the compiler can do in the worst case: in IDEs, pathological short code that causes a lot of computation is both more problematic (one does not simply In the limit, perfectly responsive iDE should be a primitive-recursive function that is limited by fuel :) |
|
@bors r+ |
|
📌 Commit 7e40df3 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors rollup |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 9, 2019
Raise the default recursion limit to 128 The previous limit of 64 is being (just) barely hit by genuine code out there, which is causing issues like rust-lang#62059 to rear their end. Ideally, we wouldn’t have such arbitrary limits at all, but while we do, it makes a lot of sense to just raise this limit whenever genuine use-cases end up hitting it. r? @pnkfelix Fixes rust-lang#62059
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 9, 2019
Raise the default recursion limit to 128 The previous limit of 64 is being (just) barely hit by genuine code out there, which is causing issues like rust-lang#62059 to rear their end. Ideally, we wouldn’t have such arbitrary limits at all, but while we do, it makes a lot of sense to just raise this limit whenever genuine use-cases end up hitting it. r? @pnkfelix Fixes rust-lang#62059
bors
added a commit
that referenced
this pull request
Jul 9, 2019
Rollup of 9 pull requests Successful merges: - #62417 (Fix ICEs when `Self` is used in type aliases) - #62450 (Raise the default recursion limit to 128) - #62470 (Prevent shrinking of "crate select" element on Firefox) - #62515 (cli: make help output for -l and -L consistent) - #62520 (Regression test for issue 42574.) - #62526 (normalize use of backticks in compiler messages for libsyntax/feature_gate.rs) - #62527 (clarify that debug_assert does not completely omits the code) - #62535 (ci: Configure $CI_JOB_NAME correctly) - #62541 (Add spastorino for rustc-guide toolstate) Failed merges: r? @ghost
|
fwiw if we incorporate chalk we remove this particular arbitrary limit, at least in trait solving (though we still have some notion of maximum size of types we have to enforce) =) |
|
discussed at T-compiler meeting. Accepted for beta backport. |
pnkfelix
added
the
beta-accepted
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Jul 22, 2019
[beta] Rollup backports Cherry picked: * rustc_target: avoid negative register counts in the SysV x86_64 ABI. #62380 * Fix ICEs when `Self` is used in type aliases #62417 * Raise the default recursion limit to 128 #62450 * Handle errors during error recovery gracefully #62604 * Correctly break out of recovery loop #62607 * Cancel unemitted diagnostics during error recovery #62666 * ci: pin awscli dependencies #62856 * Ensure that checkout is with \n line endings #62564 Rolled up: * [beta] Backport #62615 #62793 * [beta] Fix #62660 #62792 r? @ghost
bors
added a commit
that referenced
this pull request
Jul 22, 2019
[beta] Rollup backports Cherry picked: * rustc_target: avoid negative register counts in the SysV x86_64 ABI. #62380 * Fix ICEs when `Self` is used in type aliases #62417 * Raise the default recursion limit to 128 #62450 * Handle errors during error recovery gracefully #62604 * Correctly break out of recovery loop #62607 * Cancel unemitted diagnostics during error recovery #62666 * ci: pin awscli dependencies #62856 * Ensure that checkout is with \n line endings #62564 Rolled up: * [beta] Backport #62615 #62793 * [beta] Fix #62660 #62792 r? @ghost
vlad20012
added a commit
to intellij-rust/intellij-rust
that referenced
this pull request
May 30, 2022
The limit has been raised in Rustc a long time ago: rust-lang/rust#62450 This affects macro expansion depth and trait solving depth
vlad20012
added a commit
to intellij-rust/intellij-rust
that referenced
this pull request
May 30, 2022
The limit has been raised in Rustc a long time ago: rust-lang/rust#62450 This affects macro expansion depth and trait solving depth
bors bot
added a commit
to intellij-rust/intellij-rust
that referenced
this pull request
May 30, 2022
8885: Raise the default recursion limit from 64 to 128 r=vlad20012 a=vlad20012 The limit has been raised in Rustc a long time ago: rust-lang/rust#62450 This affects max macro expansion depth and max trait solving depth. changelog: Expand macros up to 128 nesting depth Co-authored-by: vlad20012 <[email protected]>
yopox
pushed a commit
to Kobzol/intellij-rust
that referenced
this pull request
Feb 27, 2023
The limit has been raised in Rustc a long time ago: rust-lang/rust#62450 This affects macro expansion depth and trait solving depth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous limit of 64 is being (just) barely hit by genuine code out there, which is causing issues like #62059 to rear their end.
Ideally, we wouldn’t have such arbitrary limits at all, but while we do, it makes a lot of sense to just raise this limit whenever genuine use-cases end up hitting it.
r? @pnkfelix
Fixes #62059